CardView - Column Chooser: Fix buttons in popup for Fluent Theme#29916
CardView - Column Chooser: Fix buttons in popup for Fluent Theme#29916Tucchhaa merged 11 commits intoDevExpress:25_1from
Conversation
| enabled: true, | ||
| }, | ||
| })); | ||
| ['generic.light', 'material.blue.light', 'fluent.blue.light'].forEach((theme) => { |
There was a problem hiding this comment.
Minor: Let's use Themes from
import { Themes } from '../../../helpers/themes';
| await t | ||
| .click(dataGrid.getColumnChooserButton()) | ||
| // act | ||
| .expect(await takeScreenshot('column-chooser.png', dataGrid.element)) |
There was a problem hiding this comment.
We can delete old screenshot now
There was a problem hiding this comment.
I already deleted it. Strange that GitHub doesn't show it.
There's no 'column-chooser.png' file in 'etalons' directory: https://github.com/Tucchhaa/DevExtreme/tree/fix_chooser_popup_btns_25_1/e2e/testcafe-devextreme/tests/dataGrid/common/etalons
| await dataGrid.apiShowColumnChooser(); | ||
|
|
||
| await t | ||
| .expect(await takeScreenshot(`column-chooser-${mode}-mode (${theme}).png`, dataGrid.element)) |
There was a problem hiding this comment.
Using spaces in file names can lead to issues in different OS. We always use '_' or '-' as a separator instead
There was a problem hiding this comment.
All cardView etalons have the same etalon naming format, so I guess there should be no issues
2 participants
No description provided.