TreeView: focus treeview element in selectAllEnabled and items empty (T1294524)#30887
Merged
juleari merged 6 commits intoDevExpress:25_2from Aug 27, 2025
Merged
TreeView: focus treeview element in selectAllEnabled and items empty (T1294524)#30887juleari merged 6 commits intoDevExpress:25_2from
juleari merged 6 commits intoDevExpress:25_2from
Conversation
Contributor
|
shorten PR name that will transform in commit message after merge |
packages/devextreme/js/__internal/ui/tree_view/tree_view.base.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/treeViewParts/focusing.js
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/tree_view/tree_view.search.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/treeViewParts/focusing.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/treeViewParts/focusing.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/treeViewParts/focusing.js
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/treeViewParts/focusing.js
Outdated
Show resolved
Hide resolved
| const isSelectAllEnabled = selectAllEnabled ?? this._selectAllEnabled(); | ||
|
|
||
| if (isSelectAllEnabled) { | ||
| const { items } = this.option(); |
Contributor
There was a problem hiding this comment.
Suggested change
| const { items } = this.option(); | |
| const { items = [] } = this.option(); |
Contributor
There was a problem hiding this comment.
After this you can remove optional changing from the condition
Contributor
Author
There was a problem hiding this comment.
i did, but why is it a preferrable way?
if items were used more than once (or if actually needed items) -- then sure
but in this case it's just ? against = [] and optional chaining is shorter and still readable and understandable
juleari
changed the title
juleari
force-pushed
the
25_2_T1294524_focused
branch
from
6df9c5d to
e1df16e
Compare
EugeniyKiyashko
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… a ScrollView