CardView: Fix the load panel overlapping the whole page#31005
Merged
Alyar666 merged 10 commits intoDevExpress:25_2from Sep 10, 2025
Merged
CardView: Fix the load panel overlapping the whole page#31005Alyar666 merged 10 commits intoDevExpress:25_2from
Alyar666 merged 10 commits intoDevExpress:25_2from
Conversation
added 9 commits
September 8, 2025 11:59
Alyar666
force-pushed
the
cardview_loader_issue_25_2
branch
from
f1b8b00 to
0b9a7eb
Compare
pomahtri
reviewed
Sep 10, 2025
| templatesRenderAsynchronously: this.options.oneWay('templatesRenderAsynchronously').value, | ||
| })); | ||
|
|
||
| private readonly commonProps = { |
Contributor
There was a problem hiding this comment.
Minor (change only there will be other changes)
Let's add here comment that
| private calculatePosition(rootElement: HTMLElement): PositionConfig { | ||
| const window = getWindow(); | ||
|
|
||
| if (rootElement.offsetHeight > window.innerHeight) { |
Contributor
There was a problem hiding this comment.
For future
It's not reactive
pomahtri
approved these changes
Sep 10, 2025
Alyar666
added a commit
to Alyar666/DevExtreme
that referenced
this pull request
Sep 10, 2025
…1005) Co-authored-by: Alyar <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.