Editor: unify value and reset(value) types (T1304359)#31023
Merged
marker-dao merged 15 commits intoDevExpress:25_1from Sep 25, 2025
Merged
Editor: unify value and reset(value) types (T1304359)#31023marker-dao merged 15 commits intoDevExpress:25_1from
marker-dao merged 15 commits intoDevExpress:25_1from
Conversation
marker-dao
force-pushed
the
25_1_T1304359_reset_value_types
branch
from
89f8c3d to
9e5c2f2
Compare
added 14 commits
September 25, 2025 10:48
…ties['value'] && Fix TextBox and TextEditor
marker-dao
force-pushed
the
25_1_T1304359_reset_value_types
branch
from
9e5c2f2 to
35fad88
Compare
| * @docid | ||
| * @hidden | ||
| */ | ||
| export interface EditorValuableObject { |
Contributor
There was a problem hiding this comment.
I don't really understand this name. Why is this object valuable?
Contributor
Author
There was a problem hiding this comment.
Because it contains value. This utility interface with @hidden doctag ensures that all types that extend EditorValuableObject will contain a value field.
Contributor
There was a problem hiding this comment.
Okay. I may not understand this to full extent, but believe me when I say that the current name is not it, even if it will be hidden.
I have a little pile of names for you to choose from. If you think one of them is okay, go on and rename. If not, I will come up with something else:
EditorHasValueObject
EditorWithValueObject
EditorValueHolderObject
Contributor
Author
There was a problem hiding this comment.
EditorOptionsWithValue
vladaskorohodova
approved these changes
Sep 25, 2025
alexslavr
approved these changes
Sep 25, 2025
Zedwag
approved these changes
Sep 25, 2025
r-farkhutdinov
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.