Scheduler: Add Appointment Form Customization to scheduler.d.ts#31127
Merged
sjbur merged 22 commits intoDevExpress:25_2from Oct 6, 2025
Merged
Scheduler: Add Appointment Form Customization to scheduler.d.ts#31127sjbur merged 22 commits intoDevExpress:25_2from
sjbur merged 22 commits intoDevExpress:25_2from
Conversation
aleksei-semikozov
requested changes
Sep 22, 2025
aleksei-semikozov
previously approved these changes
Sep 22, 2025
| // Form | ||
| // Toolbar | ||
| // Options | ||
| type IItemProps = React.PropsWithChildren<{ |
Contributor
There was a problem hiding this comment.
Is it expected that toolbar item props have been merged with form item props?
Looks like it can cause inadequate props typing
Contributor
There was a problem hiding this comment.
Yes, this is expected behavior. In metadata we merge complex options (configuration components) with same option name (item). I agree, it looks bad here. For better typing specific form items are available (SimpleItem, GroupItem, TabbedItem, etc)
…_25_2 # Conflicts: # packages/devextreme-angular/src/ui/scheduler/index.ts # packages/devextreme-angular/src/ui/scheduler/nested/editing.ts # packages/devextreme-react/src/scheduler.ts # packages/devextreme/js/ui/scheduler.d.ts # packages/devextreme/ts/dx.all.d.ts
# Conflicts: # packages/devextreme-angular/src/ui/scheduler/index.ts
mpreyskurantov
changed the title
mpreyskurantov
approved these changes
Oct 2, 2025
sjbur
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.