dxDiagram - fix bubble mousedown events, scrollbar (T1305123, T1304998)#31152
Merged
romanresh merged 1 commit intoDevExpress:24_2from Sep 24, 2025
Merged
dxDiagram - fix bubble mousedown events, scrollbar (T1305123, T1304998)#31152romanresh merged 1 commit intoDevExpress:24_2from
romanresh merged 1 commit intoDevExpress:24_2from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the devexpress-diagram package version and fixes positioning issues related to properties panel toolbars when native scrolling is enabled in dxDiagram components.
- Updates devexpress-diagram from version 2.2.19 to 2.2.24
- Introduces different offset values for properties panel positioning based on native scrolling option
- Updates test assertions to reflect new page size values
Reviewed Changes
Copilot reviewed 3 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates devexpress-diagram package version from 2.2.19 to 2.2.24 |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/diagramParts/options.tests.js | Updates test assertions for page size width/height values to match new expected values |
| packages/devextreme/js/ui/diagram/ui.diagram.js | Adds conditional offset logic for properties panel positioning based on useNativeScrolling option |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| at: 'right bottom', | ||
| of: $parent, | ||
| offset: '-' + DIAGRAM_FLOATING_PANEL_OFFSET + ' -' + DIAGRAM_FLOATING_PANEL_OFFSET | ||
| offset: `-${offset}px -${offset}px` |
There was a problem hiding this comment.
The offset string format has changed from number concatenation to template literal with 'px' units. Ensure this change in format is compatible with the positionUtils.setup function, as it may expect unitless values or a different format.
Suggested change
| offset: `-${offset}px -${offset}px` | |
| offset: '-' + offset + ' -' + offset |
nightskylark
approved these changes
Sep 24, 2025
alexslavr
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.