Skip to content

dxDiagram - fix bubble mousedown events, scrollbar (T1305123, T1304998)#31152

Merged
romanresh merged 1 commit intoDevExpress:24_2from
romanresh:24_2
Sep 24, 2025
Merged

dxDiagram - fix bubble mousedown events, scrollbar (T1305123, T1304998)#31152
romanresh merged 1 commit intoDevExpress:24_2from
romanresh:24_2

Conversation

@romanresh
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the devexpress-diagram package version and fixes positioning issues related to properties panel toolbars when native scrolling is enabled in dxDiagram components.

  • Updates devexpress-diagram from version 2.2.19 to 2.2.24
  • Introduces different offset values for properties panel positioning based on native scrolling option
  • Updates test assertions to reflect new page size values

Reviewed Changes

Copilot reviewed 3 out of 10 changed files in this pull request and generated 1 comment.

File Description
pnpm-workspace.yaml Updates devexpress-diagram package version from 2.2.19 to 2.2.24
packages/devextreme/testing/tests/DevExpress.ui.widgets/diagramParts/options.tests.js Updates test assertions for page size width/height values to match new expected values
packages/devextreme/js/ui/diagram/ui.diagram.js Adds conditional offset logic for properties panel positioning based on useNativeScrolling option
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

at: 'right bottom',
of: $parent,
offset: '-' + DIAGRAM_FLOATING_PANEL_OFFSET + ' -' + DIAGRAM_FLOATING_PANEL_OFFSET
offset: `-${offset}px -${offset}px`
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The offset string format has changed from number concatenation to template literal with 'px' units. Ensure this change in format is compatible with the positionUtils.setup function, as it may expect unitless values or a different format.

Suggested change
offset: `-${offset}px -${offset}px`
offset: '-' + offset + ' -' + offset

Copilot uses AI. Check for mistakes.
@romanresh romanresh merged commit b1d439e into DevExpress:24_2 Sep 24, 2025
384 of 385 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants