Skip to content

Conversation

@chaosmirage
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a custom Nx plugin (nx-infra-plugin) to optimize and modernize the build system for the DevExtreme React wrapper package. The changes replace the existing Gulp-based build infrastructure with Nx executors, providing better caching, task orchestration, and maintainability.

Key Changes:

  • Created a new nx-infra-plugin package with 8 custom Nx executors for common build tasks
  • Migrated devextreme-react build pipeline from Gulp to Nx executors
  • Removed Gulp dependencies and replaced with TypeScript-based build tooling

Reviewed Changes

Copilot reviewed 93 out of 119 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
packages/nx-infra-plugin/src/**/*.ts New Nx plugin source files implementing 8 executors (clean, build-typescript, copy-files, prepare-submodules, etc.) and shared utilities
packages/nx-infra-plugin/prod/**/*.js Compiled CommonJS output from TypeScript source
packages/nx-infra-plugin/*.json TypeScript and project configuration for the plugin package
packages/devextreme-react/project.json Migrated build targets from Gulp to Nx executors with proper dependency chains
packages/devextreme-react/package.json Removed Gulp dependencies and updated npm scripts to use Nx commands
packages/devextreme-react/gulpfile.js Deleted 240-line Gulp build script
packages/devextreme-react/build.config.js Deleted build configuration (replaced by executor options)
nx.json Registered the new plugin in workspace configuration
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@chaosmirage chaosmirage force-pushed the chore/build-optimization branch 5 times, most recently from 1a2c38e to d2edddf Compare October 27, 2025 10:40
@chaosmirage chaosmirage force-pushed the chore/build-optimization branch 2 times, most recently from 4bde07d to bc7e83c Compare October 27, 2025 20:29
@chaosmirage chaosmirage force-pushed the chore/build-optimization branch from bc7e83c to 22f1586 Compare October 27, 2025 21:14
@chaosmirage chaosmirage changed the title Chore/build optimization chore(devextreme-react): replace Gulp with NX plugin Oct 27, 2025
@chaosmirage chaosmirage marked this pull request as ready for review October 27, 2025 21:15
Copilot AI review requested due to automatic review settings October 27, 2025 21:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 96 out of 122 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Copilot AI review requested due to automatic review settings October 29, 2025 09:07
@chaosmirage chaosmirage force-pushed the chore/build-optimization branch from 07f88bf to bf17449 Compare October 29, 2025 09:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 86 out of 111 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

"scripts": {
"format:check": "prettier --check .",
"format": "prettier --write .",
"build": "nx build nx-infra-plugin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running pnpm run build from workspace dir packages/nx-infra-plugin will fail with NX Cannot find project 'nx-infra-plugin'. Because NX project has different name with devextreme-* prefix. Though it works fine from repo root nx run devextreme-infra-plugin:build

@@ -0,0 +1,33 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered running pnpm run build on postinstall?

Copilot AI review requested due to automatic review settings October 30, 2025 11:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 53 out of 55 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants