Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the Angular package migration to Nx, moving it back to a Gulp-based build system while keeping React and Vue packages on Nx. The change removes Angular-specific Nx executors and dependencies.
Key changes:
- Migrated devextreme-angular from Nx executors back to Gulp build system
- Removed Angular-specific executors (karma-multi-env, build-angular-library, generate-component-names) from nx-infra-plugin
- Simplified nx-infra-plugin by removing fs-extra, ng-packagr, and karma peer dependencies
- Updated React and Vue package configurations to use simplified Nx targets
Reviewed changes
Copilot reviewed 48 out of 51 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/build-all.ts | Fixed pack command flag syntax for Angular with descriptions |
| tsconfig.json | Cosmetic formatting changes to types array and path ordering |
| pnpm-lock.yaml | Added Gulp-related dependencies for Angular, removed ng-packagr/karma from nx-infra-plugin |
| packages/nx-infra-plugin/src/utils/file-operations.ts | Replaced fs-extra with native fs.promises, simplified ensureDir implementation |
| packages/nx-infra-plugin/src/executors/clean/executor.ts | Refactored with three cleaning modes (simple, shallow, recursive) |
| packages/nx-infra-plugin/src/executors/generate-components/executor.ts | Removed Angular generator, added cleaning before generation for React/Vue |
| packages/nx-infra-plugin/src/executors/copy-files/executor.ts | Removed directory copying support, now only handles files |
| packages/nx-infra-plugin/src/executors/add-license-headers/executor.ts | Simplified options by removing custom patterns and separators |
| packages/nx-infra-plugin/src/executors/build-typescript/executor.ts | Removed Windows-specific OS detection conditionals |
| packages/nx-infra-plugin/package.json | Removed fs-extra dependency and ng-packagr/karma peer dependencies |
| packages/nx-infra-plugin/executors.json | Removed karma-multi-env, build-angular-library, and generate-component-names executors |
| packages/devextreme-angular/gulpfile.js | New Gulp build configuration with component generation, building, testing tasks |
| packages/devextreme-angular/build.config.js | New build configuration file defining paths and generator settings |
| packages/devextreme-angular/project.json | Simplified to use nx:run-script executor delegating to Gulp |
| packages/devextreme-angular/package.json | Updated scripts to use Gulp, added Gulp dependencies |
| packages/devextreme-react/project.json | Restructured build targets with explicit dependencies, removed run-commands |
| packages/devextreme-vue/project.json | Restructured build targets with explicit dependencies, removed run-commands |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
alexslavr
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.