Skip to content

Revert/migrate angular to nx#31968

Merged
alexslavr merged 3 commits into25_2from
revert/migrate-angular-to-nx
Dec 12, 2025
Merged

Revert/migrate angular to nx#31968
alexslavr merged 3 commits into25_2from
revert/migrate-angular-to-nx

Conversation

@chaosmirage
Copy link
Contributor

No description provided.

@chaosmirage chaosmirage requested a review from a team December 11, 2025 23:07
@chaosmirage chaosmirage self-assigned this Dec 11, 2025
Copilot AI review requested due to automatic review settings December 11, 2025 23:07
@chaosmirage chaosmirage removed the request for review from a team December 11, 2025 23:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the Angular package migration to Nx, moving it back to a Gulp-based build system while keeping React and Vue packages on Nx. The change removes Angular-specific Nx executors and dependencies.

Key changes:

  • Migrated devextreme-angular from Nx executors back to Gulp build system
  • Removed Angular-specific executors (karma-multi-env, build-angular-library, generate-component-names) from nx-infra-plugin
  • Simplified nx-infra-plugin by removing fs-extra, ng-packagr, and karma peer dependencies
  • Updated React and Vue package configurations to use simplified Nx targets

Reviewed changes

Copilot reviewed 48 out of 51 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tools/scripts/build-all.ts Fixed pack command flag syntax for Angular with descriptions
tsconfig.json Cosmetic formatting changes to types array and path ordering
pnpm-lock.yaml Added Gulp-related dependencies for Angular, removed ng-packagr/karma from nx-infra-plugin
packages/nx-infra-plugin/src/utils/file-operations.ts Replaced fs-extra with native fs.promises, simplified ensureDir implementation
packages/nx-infra-plugin/src/executors/clean/executor.ts Refactored with three cleaning modes (simple, shallow, recursive)
packages/nx-infra-plugin/src/executors/generate-components/executor.ts Removed Angular generator, added cleaning before generation for React/Vue
packages/nx-infra-plugin/src/executors/copy-files/executor.ts Removed directory copying support, now only handles files
packages/nx-infra-plugin/src/executors/add-license-headers/executor.ts Simplified options by removing custom patterns and separators
packages/nx-infra-plugin/src/executors/build-typescript/executor.ts Removed Windows-specific OS detection conditionals
packages/nx-infra-plugin/package.json Removed fs-extra dependency and ng-packagr/karma peer dependencies
packages/nx-infra-plugin/executors.json Removed karma-multi-env, build-angular-library, and generate-component-names executors
packages/devextreme-angular/gulpfile.js New Gulp build configuration with component generation, building, testing tasks
packages/devextreme-angular/build.config.js New build configuration file defining paths and generator settings
packages/devextreme-angular/project.json Simplified to use nx:run-script executor delegating to Gulp
packages/devextreme-angular/package.json Updated scripts to use Gulp, added Gulp dependencies
packages/devextreme-react/project.json Restructured build targets with explicit dependencies, removed run-commands
packages/devextreme-vue/project.json Restructured build targets with explicit dependencies, removed run-commands
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@alexslavr alexslavr merged commit bed3156 into 25_2 Dec 12, 2025
250 of 326 checks passed
@alexslavr alexslavr deleted the revert/migrate-angular-to-nx branch December 12, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants