chore(devextreme): create the localization gulp task alternative based on nx#32047
Merged
chaosmirage merged 10 commits intoDevExpress:26_1from Jan 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR creates a new Nx-based localization executor to replace the existing Gulp-based localization task, modernizing the build system infrastructure. The implementation generates localization message files and TypeScript CLDR data modules, and enhances the add-license-headers executor with custom template support.
Key Changes
- New localization executor that generates message files and CLDR TypeScript modules using lodash templates
- Enhanced add-license-headers executor with custom template support, EULA URL configuration, and prepend-after-license functionality
- Integration of localization tasks into devextreme project.json with proper Nx caching and dependency management
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds lodash and @types/lodash dependencies; includes minor formatting change to Q package deprecation message |
| packages/nx-infra-plugin/src/executors/localization/schema.ts | Defines TypeScript interface for localization executor options |
| packages/nx-infra-plugin/src/executors/localization/schema.json | JSON schema for localization executor with configurable paths and skip flags |
| packages/nx-infra-plugin/src/executors/localization/executor.ts | Core implementation that generates localization messages and CLDR modules, replacing Gulp-based approach |
| packages/nx-infra-plugin/src/executors/localization/executor.e2e.spec.ts | E2E tests verifying message file and CLDR module generation |
| packages/nx-infra-plugin/src/executors/add-license-headers/schema.ts | Extends schema with custom template, EULA URL, and prepend options |
| packages/nx-infra-plugin/src/executors/add-license-headers/schema.json | Adds JSON schema definitions for new license header features |
| packages/nx-infra-plugin/src/executors/add-license-headers/executor.ts | Refactors and extends license header executor with custom template support using lodash |
| packages/nx-infra-plugin/src/executors/add-license-headers/executor.e2e.spec.ts | Adds test for custom license template and consolidates header validation tests |
| packages/nx-infra-plugin/package.json | Adds lodash and @types/lodash as dependencies |
| packages/nx-infra-plugin/executors.json | Registers new localization executor |
| packages/devextreme/project.json | Defines new localization build targets (generate, headers, composite) with Nx caching |
| nx.json | Adds named inputs for devextreme sources and build configuration |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
cbb0822 to
cbbb0aa
Compare
cbbb0aa to
2e1c102
Compare
2e1c102 to
94fe0f0
Compare
94fe0f0 to
e07f880
Compare
e07f880 to
6350d27
Compare
packages/nx-infra-plugin/src/executors/localization/executor.e2e.spec.ts
Show resolved
Hide resolved
6350d27 to
71ffe30
Compare
alexslavr
previously approved these changes
Jan 26, 2026
71ffe30 to
6580bb1
Compare
packages/nx-infra-plugin/src/executors/localization/executor.e2e.spec.ts
Show resolved
Hide resolved
packages/nx-infra-plugin/src/executors/localization/executor.e2e.spec.ts
Show resolved
Hide resolved
mpreyskurantov
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.