Demos: Fix TS problems and make TS improvements in strict mode (Navigation) #32072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TypeScript problems and improves type safety across Navigation and StrictMode demos, enabling TypeScript checking for several demo categories (Button, Charts, Form, Gauges, List, Menu, ScrollView, Splitter, Tabs, TreeView).
Key Changes:
- Removed TypeScript exclusions for 14 demo categories from
tsconfig.react-check.json - Added proper null/undefined checks with optional chaining throughout demos
- Added explicit type annotations to functions and variables
- Created type definition files where missing
- Converted utility objects/services to properly typed exports
Reviewed changes
Copilot reviewed 141 out of 141 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/tsconfig.react-check.json | Removed exclusions for Button, Charts, Form, Gauges, List, Menu, NavigationOverview, ScrollView, Splitter, Tabs, and TreeView demos |
| apps/demos/Demos/TreeView/**/React/*.tsx | Added null checks for itemData, optional chaining for properties, and updated state types to allow undefined |
| apps/demos/Demos/Gauges/**/React/*.tsx | Added type annotations to functions, proper null checks, and created missing type definition files |
| apps/demos/Demos/Charts/**/React/*.tsx | Extensive type improvements: proper event types, null checks, return type annotations, and type definition files |
| apps/demos/Demos/Form/**/React/*.tsx | Fixed prop spreading order, updated state types, and improved null safety |
| apps/demos/Demos/Menu/Scrolling/React/*.tsx | Added null check for submenuContainer before accessing style property |
| apps/demos/Demos/List/Selection/React/*.tsx | Simplified boolean state type and added nullish coalescing |
| apps/demos/Demos/ScrollView/Overview/React/*.tsx | Added explicit type for content state and proper undefined handling |
| apps/demos/Demos/Splitter/Overview/React/*.tsx | Added proper ref typing and instanceof check before DOM manipulation |
| apps/demos/Demos/Button/PredefinedTypes/React/*.tsx | Added nullish coalescing for option retrieval |
apps/demos/Demos/Gauges/SubvalueIndicatorsRuntimeCustomization/ReactJs/App.js
Outdated
Show resolved
Hide resolved
apps/demos/Demos/Gauges/SubvalueIndicatorsRuntimeCustomization/React/App.tsx
Outdated
Show resolved
Hide resolved
dmlvr
previously approved these changes
Dec 30, 2025
dmlvr
previously approved these changes
Dec 30, 2025
pharret31
changed the title
dmlvr
previously approved these changes
Dec 30, 2025
dmlvr
approved these changes
Dec 30, 2025
pharret31
added a commit
to pharret31/DevExtreme
that referenced
this pull request
Dec 30, 2025
pharret31
added a commit
that referenced
this pull request
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.