Skip to content

Conversation

@pharret31
Copy link
Contributor

No description provided.

@pharret31 pharret31 marked this pull request as ready for review December 31, 2025 00:19
Copilot AI review requested due to automatic review settings December 31, 2025 00:19
@pharret31 pharret31 requested review from a team as code owners December 31, 2025 00:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables TypeScript strict mode checking for editor-related React demos by removing exclusions from tsconfig.react-check.json and fixing TypeScript issues. The changes focus on improving type safety across demos for components like Autocomplete, Calendar, Chat, NumberBox, SelectBox, Slider, TextArea, Toast, Validation, and others.

  • Removes 44 demo exclusions from TypeScript checking configuration
  • Adds proper null/undefined handling with optional chaining and nullish coalescing
  • Improves type annotations and imports using type keyword for type-only imports
  • Refactors code to eliminate redundant intermediate variables

Reviewed changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
tsconfig.react-check.json Removes exclusions for editor demos now passing strict TypeScript checks
Validation/Overview (React & ReactJs) Adds optional chaining for validator ref access
Toast/Stack (React & ReactJs) Changes null to undefined for NumberBox default values
TextArea/Overview (React & ReactJs) Changes maxLength state from null to undefined
TagBox/* (React & ReactJs) Adds null safety checks and improves type annotations
Stepper/FormIntegration (React & ReactJs) Adds null coalescing for date array access
SpeechToText/Overview (React & ReactJs) Derives languages array from langMap object, adds Language type
Slider/Overview (React) Adds type annotation to format function
SelectBox/* (React) Adds proper TypeScript interfaces for components and type-only imports
RangeSlider/Overview (React & ReactJs) Extracts min/max constants, adds null coalescing for value handling
RadioGroup/Overview (React) Adds type annotation to renderCustomItem function
Popup/Overview (React & ReactJs) Adds optional chaining for employee property access
NumberBox/Overview (React & ReactJs) Adds optional chaining for event.key access
Map/Markers (React & ReactJs) Changes marker URL state from null to undefined
HtmlEditor/* (React & ReactJs) Removes redundant variables, adds null coalescing, improves type imports
FileUploader/FileUploading (React & ReactJs) Adds early return guard for null value
DropDownButton/Overview (React & ReactJs) Adds null handling for color values and querySelector results
DropDownBox/MultipleSelection (React) Adds explicit type annotation in forEach callback
Common/PopupAndNotificationsOverview (React & ReactJs) Adds null check guard clause for updatedCurrentHouse
Common/EditorsRightToLeftSupport (React & ReactJs) Changes className from null to undefined
Chat/* (React & ReactJs) Adds extensive null safety, type improvements, and proper type casting
Calendar/* (React & ReactJs) Changes cellComponent and disabledDates from null to undefined
Autocomplete/Overview (React & ReactJs) Refactors loadOptions iteration with proper typing

@pharret31 pharret31 merged commit fe49184 into DevExpress:26_1 Jan 7, 2026
157 of 161 checks passed
@pharret31 pharret31 deleted the 26_1_2978-strict-mode branch January 7, 2026 09:03
pharret31 added a commit to pharret31/DevExtreme that referenced this pull request Jan 7, 2026
pharret31 added a commit that referenced this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants