Scheduler: fix ts issues in demos in strict mode #32101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pharret31
reviewed
Jan 7, 2026
pharret31
reviewed
Jan 7, 2026
apps/demos/Demos/Scheduler/GoogleCalendarIntegration/React/App.tsx
Outdated
Show resolved
Hide resolved
pharret31
reviewed
Jan 7, 2026
| }; | ||
|
|
||
| const setComponentAria = (element) => { | ||
| const setComponentAria = (element: dxElementWrapper) => { |
Contributor
There was a problem hiding this comment.
I think the DxElement would be a better option here
Contributor
Author
There was a problem hiding this comment.
When I'm trying to use DxElement the error persists
Property 'attr' does not exist on type 'HTMLElement'.
I found other way, take a look, please
pharret31
reviewed
Jan 7, 2026
| }, | ||
| ]; | ||
| export const schedulerDataSource = new DataSource(data); | ||
| export const schedulerDataSource = new DataSource(data) as unknown as DataSource<SchedulerTypes.Appointment>; |
Contributor
There was a problem hiding this comment.
Is there a way to type that without 'as unknown'?
Contributor
Author
There was a problem hiding this comment.
I researched other demos and found way to use data instead of dataSource, like this https://github.com/DevExpress/DevExtreme/blob/577ad2c1d9e95357851643cbcfcae8bda262d223/apps/demos/Demos/Scheduler/Adaptability/React/App.tsx
dmlvr
changed the title
dmlvr
changed the title
pharret31
reviewed
Jan 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TypeScript strict mode issues in Scheduler demos by enabling strict type checking and resolving the resulting compilation errors. The changes primarily involve improving type safety through better import patterns, null safety checks, and explicit type conversions.
Key Changes
- Removed Scheduler and Pagination demos from the strict mode exclusion list in
tsconfig.react-check.json, enabling strict type checking for these demos - Separated type-only imports using the
typekeyword to comply withverbatimModuleSyntaxconfiguration - Added null safety checks with optional chaining (
?.) to handle potentially undefined values - Replaced direct data arrays with
DataSourcewrapper to ensure proper type handling
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/tsconfig.react-check.json | Removed Scheduler/Pagination exclusions; added new component exclusions to expand strict type checking coverage |
| apps/demos/Demos/Scheduler//React/.tsx | Separated type-only imports from value imports using type keyword |
| apps/demos/Demos/Scheduler/Toolbar/React/* | Replaced DataSource wrapper with plain array, added explicit Number() conversion for cellDuration |
| apps/demos/Demos/Scheduler/Templates/React/* | Added null safety checks with optional chaining for form instance operations |
| apps/demos/Demos/Scheduler/Editing/React/* | Added nullish coalescing operator to handle potentially undefined text values |
| apps/demos/Demos/Scheduler/CellTemplates/React/* | Changed null to undefined for className, added type guards, improved null safety |
| apps/demos/Demos/Scheduler/ContextMenu/React/* | Added optional chaining for potentially undefined properties |
| apps/demos/Demos/Scheduler/GoogleCalendarIntegration/React/* | Added proper typing for getData function parameters |
| apps/demos/Demos/Pagination/Overview/React/* | Separated type-only imports using type keyword |
Comments suppressed due to low confidence (1)
apps/demos/tsconfig.react-check.json:61
- The
Demos/Localization/**/React/**/*.tsandDemos/Localization/**/React/**/*.tsxpatterns are duplicated in the exclude list. Lines 30-31 and lines 60-61 contain the same exclusion patterns. One set should be removed to avoid redundancy.
sjbur
previously approved these changes
Jan 7, 2026
Tucchhaa
reviewed
Jan 7, 2026
pharret31
previously approved these changes
Jan 7, 2026
apps/demos/Demos/Scheduler/Templates/React/MovieInfoContainer.tsx
Outdated
Show resolved
Hide resolved
apps/demos/Demos/Scheduler/Templates/ReactJs/MovieInfoContainer.js
Outdated
Show resolved
Hide resolved
Tucchhaa
approved these changes
Jan 8, 2026
pharret31
approved these changes
Jan 8, 2026
dmlvr
added a commit
to dmlvr/DevExtreme
that referenced
this pull request
Jan 8, 2026
Co-authored-by: EugeniyKiyashko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.