fix(nx-infra-plugin): normalize paths for cross-platform angular component generation #32118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosmirage
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes cross-platform path handling issues in Angular component generation by normalizing file paths to use forward slashes consistently across Windows and Unix systems.
Key changes:
- Added
normalize-pathdependency (version 3.0.0) to handle cross-platform path normalization - Applied path normalization to
componentsDir,indexFileName, andmetadataDirvariables in the Angular generator
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/nx-infra-plugin/package.json | Added normalize-path runtime dependency and @types/normalize-path dev dependency |
| pnpm-lock.yaml | Updated lockfile with new normalize-path package entries |
| packages/nx-infra-plugin/src/executors/generate-components/angular-generator.ts | Imported normalize-path and applied normalization to three path variables used for Angular component generation |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
alexslavr
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.