-
Notifications
You must be signed in to change notification settings - Fork 665
DataGrid - Testcafe tests - Row dragging: unskip tests #32313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 26_1
Are you sure you want to change the base?
DataGrid - Testcafe tests - Row dragging: unskip tests #32313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR re-enables previously marked unstable DataGrid row-dragging TestCafe tests so they now run as part of the normal suite.
Changes:
- Removed
test.meta({ unstable: true })from the “Footer should not be hidden during auto scrolling when virtual scrollling is specified” test so it always runs. - Removed
test.meta({ unstable: true })from “Dragging with scrolling should be prevented by e.cancel (T1179555)”. - Removed
test.meta({ unstable: true })from “toIndex should not be corrected when source item gets removed from DOM” and “Rows should appear correctly during dragging when virtual scrolling is enabled and rowDragging.dropFeedbackMode = "push"”.
e2e/testcafe-devextreme/tests/dataGrid/common/rowDragging/functional.ts
Outdated
Show resolved
Hide resolved
…rolling is enabled and rowDragging.dropFeedbackMode = "push"' test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
e2e/testcafe-devextreme/tests/dataGrid/common/rowDragging/functional.ts:469
- There is a typo in the test title: "virtual scrollling" should be "virtual scrolling" to keep the description readable and consistent with other tests.
df7c255 to
738ad14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 5 changed files in this pull request and generated no new comments.
No description provided.