Skip to content

Demos: fix eslint issues#32560

Merged
pharret31 merged 2 commits intoDevExpress:26_1from
pharret31:26_1_3444-fix-eslint-errors-in-demos
Feb 13, 2026
Merged

Demos: fix eslint issues#32560
pharret31 merged 2 commits intoDevExpress:26_1from
pharret31:26_1_3444-fix-eslint-errors-in-demos

Conversation

@pharret31
Copy link
Contributor

No description provided.

@pharret31 pharret31 self-assigned this Feb 13, 2026
@pharret31 pharret31 marked this pull request as ready for review February 13, 2026 10:29
@pharret31 pharret31 requested review from a team as code owners February 13, 2026 10:29
Copilot AI review requested due to automatic review settings February 13, 2026 10:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses eslint issues in demo applications by fixing two types of violations:

  1. Vue component props: Making props optional to align with TypeScript and Vue best practices
  2. Angular error handling: Changing throw statements to use Error objects instead of string literals
  3. Code formatting: Fixing spacing in type annotations

Changes:

  • Made Vue component props optional (adding ? suffix) while ensuring default values are provided via withDefaults()
  • Updated Angular error handlers to throw Error objects (throw new Error(...)) instead of string literals (throw '...')
  • Fixed spacing in a TypeScript type annotation

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/demos/Demos/Toast/Overview/Vue/ProductItem.vue Made product prop optional with default value
apps/demos/Demos/Stepper/FormIntegration/Vue/RoomMealPlanTemplate.vue Made formData prop optional with default value
apps/demos/Demos/Stepper/FormIntegration/Vue/GuestsTemplate.vue Made formData prop optional with default value
apps/demos/Demos/Stepper/FormIntegration/Vue/DatesTemplate.vue Made formData prop optional with default value
apps/demos/Demos/Stepper/FormIntegration/Vue/ConfirmationTemplate.vue Made formData and isConfirmed props optional with default values
apps/demos/Demos/Stepper/FormIntegration/Vue/AdditionalTemplate.vue Made formData prop optional with default value
apps/demos/Demos/Diagram/UICustomization/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal
apps/demos/Demos/Diagram/ReadOnly/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal
apps/demos/Demos/Diagram/Overview/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal
apps/demos/Demos/Diagram/CustomShapesWithTexts/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal
apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/Vue/CustomShapeTemplate.vue Made employee, editEmployee, and deleteEmployee props optional with default values
apps/demos/Demos/Diagram/CustomShapesWithTemplates/Vue/CustomShapeTemplate.vue Made employee and showInfo props optional with default values
apps/demos/Demos/Diagram/CustomShapesWithIcons/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal
apps/demos/Demos/Diagram/Containers/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal
apps/demos/Demos/Diagram/Adaptability/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal
apps/demos/Demos/Charts/SignalRService/Vue/TooltipTemplate.vue Made pointInfo prop optional with default value
apps/demos/Demos/Charts/Colorization/Angular/app/app.component.ts Fixed spacing in type annotation (removed extra space)
apps/demos/Demos/Charts/ClientSideDataProcessing/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal
apps/demos/Demos/Charts/BarSparklines/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal
apps/demos/Demos/Autocomplete/Overview/Angular/app/app.component.ts Changed error handler to throw Error object instead of string literal

@pharret31 pharret31 merged commit 3afe2b4 into DevExpress:26_1 Feb 13, 2026
271 of 279 checks passed
@pharret31 pharret31 deleted the 26_1_3444-fix-eslint-errors-in-demos branch February 13, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants