Skip to content

Disable zoneless mode #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dxvladislavvolkov merged 4 commits into from
May 12, 2025
Merged

Disable zoneless mode #954

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0c63ef
Add zoneless flag
dxvladislavvolkov May 6, 2025
6c6959b
Fix test using threshold
dxvladislavvolkov May 8, 2025
fc36b78
Fix test
dxvladislavvolkov May 8, 2025
628595b
Update image snapshot
dxvladislavvolkov May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/devextreme-cli/src/applications/application.angular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const { extractToolingVersion, toolingVersionOptionName } = require('../utility/
const schematicsVersion = latestVersions['devextreme-schematics'] || 'latest';

const minNgCliVersion = new semver('17.0.0');
const ngCliWithZoneless = new semver('20.0.0');

async function runSchematicCommand(schematicCommand, options, evaluatingOptions) {
const collectionName = 'devextreme-schematics';
Expand Down Expand Up @@ -76,6 +77,7 @@ const install = async(options) => {

const create = async(appName, options) => {
const layout = await getLayoutInfo(options.layout);
const currentNgVersion = ngVersion.getNgCliVersion().version;

const commandArguments = [
'new',
Expand All @@ -88,6 +90,10 @@ const create = async(appName, options) => {
'--ssr=false'
];

if(ngCliWithZoneless.compare(currentNgVersion) <= 0) {
commandArguments.push('--zoneless=false');
}

await runNgCommand(commandArguments, options);

const appPath = path.join(process.cwd(), appName);
Expand Down
Loading