Skip to content

chore: fix unchanged files with check annotations #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpreyskurantov merged 6 commits into from
Mar 10, 2025
Merged

chore: fix unchanged files with check annotations #390

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35430f2
'CardAnalytics' is defined but never used
mpreyskurantov Feb 28, 2025
cdd11dc
Prop 'title' requires default value to be set (non optional, like in …
mpreyskurantov Feb 28, 2025
b3bb58d
Unexpected console statement (github actions / aka eslint)
mpreyskurantov Feb 28, 2025
8a2d2b0
Prop 'tone' requires default value to be set
mpreyskurantov Mar 3, 2025
3fbe6fd
Prop 'tone' requires default value to be set (undefined -> eslint)
mpreyskurantov Mar 3, 2025
1b4bbd4
Prop 'tone' requires default value to be set (eslint -> defineProps)
mpreyskurantov Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/shell/copy-themes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ copyFile(
join(__dirname, 'src', 'app', 'themes.json'),
(err) => {
if (err) throw err;
console.log('themes.json copied');
console.log('themes.json copied'); // eslint-disable-line no-console
},
);
5 changes: 2 additions & 3 deletions packages/vue/src/components/library/ticker-card.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,12 @@
import { formatPrice } from '@/utils/formatters';
import { Sales, SalesOrOpportunitiesByCategory } from '@/types/analytics';
import { computed, withDefaults } from 'vue';
import CardAnalytics from '@/components/library/card-analytics.vue';

const props = withDefaults(
defineProps<{
icon: string,
tone?: 'warning' | 'info',
title? : string,
tone?: 'warning' | 'info', // eslint-disable-line vue/require-default-prop
title: string,
data?: SalesOrOpportunitiesByCategory | Sales | null,
total?: string | null,
percentage: number,
Expand Down
Loading