-
Notifications
You must be signed in to change notification settings - Fork 0
drivers: stepper: a4988 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
015d828
to
14bb550
Compare
14bb550
to
0c55abb
Compare
Add a4998 2-phase motor controller driver Signed-off-by: Marvin Ouma <[email protected]>
0c55abb
to
224ca5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pancakem it's a little hard to review with the linter screaming , would it be possible to run that then I can review please
add_subdirectory_ifdef(CONFIG_STEPPER_ADI_TMC adi_tmc) | ||
add_subdirectory_ifdef(CONFIG_STEPPER_TI ti) | ||
add_subdirectory_ifdef(CONFIG_STEP_DIR_STEPPER step_dir) | ||
add_subdirectory_ifdef(CONFIG_STEPPER_ALLEGRO allegro) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pancakem perhaps we can move this to an alphabetical order to avoid the warnings?
|
||
static int a4988_stepper_enable(const struct device *dev, const bool enable) | ||
{ | ||
/* enable and sleep pins need to be set logic low to be on */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Pancakem the data sheet seems not to agree on this see page 10 on here https://www.pololu.com/file/download/A4988.pdf?file_id=0J450
Current code does not build on Cortex-M0, seems like it does not like subs: Error: instruction not supported in Thumb16 mode -- `subs r3,#1' Adding a unified assembler language declaration in the snippet seems to fix the problem, also add an M0+ board so this is tested in CI. Signed-off-by: Fabio Baltieri <[email protected]>
Add support for NV12/NV21, NV16/NV61 and YUV420/YVU420 (semi)planar formats which can be output by the main #1 pipe. Signed-off-by: Alain Volmat <[email protected]>
Add a4998 2-phase motor controller driver