Skip to content

Conversation

Pancakem
Copy link
Collaborator

Add a4998 2-phase motor controller driver

@Pancakem
Copy link
Collaborator Author

@zacck
Testing the driver is quite simple.
Follow this hook up guide to connect the board to your controller.
The sample is written and tested stm32_min_dev board if you have one you can use the already existing gpio mapping.

Add a4998 2-phase motor controller driver

Signed-off-by: Marvin Ouma <[email protected]>
Copy link

@zacck zacck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pancakem it's a little hard to review with the linter screaming , would it be possible to run that then I can review please

add_subdirectory_ifdef(CONFIG_STEPPER_ADI_TMC adi_tmc)
add_subdirectory_ifdef(CONFIG_STEPPER_TI ti)
add_subdirectory_ifdef(CONFIG_STEP_DIR_STEPPER step_dir)
add_subdirectory_ifdef(CONFIG_STEPPER_ALLEGRO allegro)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pancakem perhaps we can move this to an alphabetical order to avoid the warnings?


static int a4988_stepper_enable(const struct device *dev, const bool enable)
{
/* enable and sleep pins need to be set logic low to be on */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Pancakem the data sheet seems not to agree on this see page 10 on here https://www.pololu.com/file/download/A4988.pdf?file_id=0J450

Pancakem pushed a commit that referenced this pull request Jun 3, 2025
Current code does not build on Cortex-M0, seems like it does not like
subs:

Error: instruction not supported in Thumb16 mode -- `subs r3,#1'

Adding a unified assembler language declaration in the snippet seems to
fix the problem, also add an M0+ board so this is tested in CI.

Signed-off-by: Fabio Baltieri <[email protected]>
Pancakem pushed a commit that referenced this pull request Sep 18, 2025
Add support for NV12/NV21, NV16/NV61 and YUV420/YVU420
(semi)planar formats which can be output by the main #1 pipe.

Signed-off-by: Alain Volmat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants