TYP: respond to review comments

Author: ngoldbaum

numpy/_core/defchararray.pyi

@@ -97,7 +97,7 @@ _CharDType_co = TypeVar(
 )
 _CharArray: TypeAlias = chararray[tuple[int, ...], dtype[_SCT]]
 
-AR_T: TypeAlias = np.ndarray[_Shape, np.dtypes.StringDType]
+_StringDTypeArray: TypeAlias = np.ndarray[_Shape, np.dtypes.StringDType]
 
 class chararray(ndarray[_ShapeType_co, _CharDType_co]):
     @overload
@@ -564,35 +564,35 @@ def add(x1: U_co, x2: U_co) -> NDArray[np.str_]: ...
 @overload
 def add(x1: S_co, x2: S_co) -> NDArray[np.bytes_]: ...
 @overload
-def add(x1: T_co, x2: T_co) -> AR_T: ...
+def add(x1: T_co, x2: T_co) -> _StringDTypeArray: ...
 
 @overload
 def multiply(a: U_co, i: i_co) -> NDArray[np.str_]: ...
 @overload
 def multiply(a: S_co, i: i_co) -> NDArray[np.bytes_]: ...
 @overload
-def multiply(a: T_co, i: i_co) -> AR_T: ...
+def multiply(a: T_co, i: i_co) -> _StringDTypeArray: ...
 
 @overload
 def mod(a: U_co, value: Any) -> NDArray[np.str_]: ...
 @overload
 def mod(a: S_co, value: Any) -> NDArray[np.bytes_]: ...
 @overload
-def mod(a: T_co, value: Any) -> AR_T: ...
+def mod(a: T_co, value: Any) -> _StringDTypeArray: ...
 
 @overload
 def capitalize(a: U_co) -> NDArray[str_]: ...
 @overload
 def capitalize(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def capitalize(a: T_co) -> AR_T: ...
+def capitalize(a: T_co) -> _StringDTypeArray: ...
 
 @overload
 def center(a: U_co, width: i_co, fillchar: U_co = ...) -> NDArray[str_]: ...
 @overload
 def center(a: S_co, width: i_co, fillchar: S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def center(a: T_co, width: i_co, fillchar: T_co = ...) -> AR_T: ...
+def center(a: T_co, width: i_co, fillchar: T_co = ...) -> _StringDTypeArray: ...
 
 def decode(
     a: S_co,
@@ -610,42 +610,42 @@ def expandtabs(a: U_co, tabsize: i_co = ...) -> NDArray[str_]: ...
 @overload
 def expandtabs(a: S_co, tabsize: i_co = ...) -> NDArray[bytes_]: ...
 @overload
-def expandtabs(a: T_co, tabsize: i_co = ...) -> AR_T: ...
+def expandtabs(a: T_co, tabsize: i_co = ...) -> _StringDTypeArray: ...
 
 @overload
 def join(sep: U_co, seq: U_co) -> NDArray[str_]: ...
 @overload
 def join(sep: S_co, seq: S_co) -> NDArray[bytes_]: ...
 @overload
-def join(sep: T_co, seq: T_co) -> AR_T: ...
+def join(sep: T_co, seq: T_co) -> _StringDTypeArray: ...
 
 @overload
 def ljust(a: U_co, width: i_co, fillchar: U_co = ...) -> NDArray[str_]: ...
 @overload
 def ljust(a: S_co, width: i_co, fillchar: S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def ljust(a: T_co, width: i_co, fillchar: T_co = ...) -> AR_T: ...
+def ljust(a: T_co, width: i_co, fillchar: T_co = ...) -> _StringDTypeArray: ...
 
 @overload
 def lower(a: U_co) -> NDArray[str_]: ...
 @overload
 def lower(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def lower(a: T_co) -> AR_T: ...
+def lower(a: T_co) -> _StringDTypeArray: ...
 
 @overload
 def lstrip(a: U_co, chars: None | U_co = ...) -> NDArray[str_]: ...
 @overload
 def lstrip(a: S_co, chars: None | S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def lstrip(a: T_co, chars: None | T_co = ...) -> AR_T: ...
+def lstrip(a: T_co, chars: None | T_co = ...) -> _StringDTypeArray: ...
 
 @overload
 def partition(a: U_co, sep: U_co) -> NDArray[str_]: ...
 @overload
 def partition(a: S_co, sep: S_co) -> NDArray[bytes_]: ...
 @overload
-def partition(a: T_co, sep: T_co) -> AR_T: ...
+def partition(a: T_co, sep: T_co) -> _StringDTypeArray: ...
 
 @overload
 def replace(
@@ -667,7 +667,7 @@ def replace(
     old: T_co,
     new: T_co,
     count: i_co = ...,
-) -> AR_T: ...
+) -> _StringDTypeArray: ...
 
 @overload
 def rjust(
@@ -686,14 +686,14 @@ def rjust(
     a: T_co,
     width: i_co,
     fillchar: T_co = ...,
-) -> AR_T: ...
+) -> _StringDTypeArray: ...
 
 @overload
 def rpartition(a: U_co, sep: U_co) -> NDArray[str_]: ...
 @overload
 def rpartition(a: S_co, sep: S_co) -> NDArray[bytes_]: ...
 @overload
-def rpartition(a: T_co, sep: T_co) -> AR_T: ...
+def rpartition(a: T_co, sep: T_co) -> _StringDTypeArray: ...
 
 @overload
 def rsplit(
@@ -719,7 +719,7 @@ def rstrip(a: U_co, chars: None | U_co = ...) -> NDArray[str_]: ...
 @overload
 def rstrip(a: S_co, chars: None | S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def rstrip(a: T_co, chars: None | T_co = ...) -> AR_T: ...
+def rstrip(a: T_co, chars: None | T_co = ...) -> _StringDTypeArray: ...
 
 @overload
 def split(
@@ -740,29 +740,28 @@ def split(
     maxsplit: None | i_co = ...,
 ) -> NDArray[object_]: ...
 
-@overload
 def splitlines(a: UST_co, keepends: None | b_co = ...) -> NDArray[np.object_]: ...
 
 @overload
 def strip(a: U_co, chars: None | U_co = ...) -> NDArray[str_]: ...
 @overload
 def strip(a: S_co, chars: None | S_co = ...) -> NDArray[bytes_]: ...
 @overload
-def strip(a: T_co, chars: None | T_co = ...) -> AR_T: ...
+def strip(a: T_co, chars: None | T_co = ...) -> _StringDTypeArray: ...
 
 @overload
 def swapcase(a: U_co) -> NDArray[str_]: ...
 @overload
 def swapcase(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def swapcase(a: T_co) -> AR_T: ...
+def swapcase(a: T_co) -> _StringDTypeArray: ...
 
 @overload
 def title(a: U_co) -> NDArray[str_]: ...
 @overload
 def title(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def title(a: T_co) -> AR_T: ...
+def title(a: T_co) -> _StringDTypeArray: ...
 
 @overload
 def translate(
@@ -781,21 +780,21 @@ def translate(
     a: T_co,
     table: str,
     deletechars: None | str = ...,
-) -> AR_T: ...
+) -> _StringDTypeArray: ...
 
 @overload
 def upper(a: U_co) -> NDArray[str_]: ...
 @overload
 def upper(a: S_co) -> NDArray[bytes_]: ...
 @overload
-def upper(a: T_co) -> AR_T: ...
+def upper(a: T_co) -> _StringDTypeArray: ...
 
 @overload
 def zfill(a: U_co, width: i_co) -> NDArray[str_]: ...
 @overload
 def zfill(a: S_co, width: i_co) -> NDArray[bytes_]: ...
 @overload
-def zfill(a: T_co, width: i_co) -> AR_T: ...
+def zfill(a: T_co, width: i_co) -> _StringDTypeArray: ...
 
 # String information
 @overload

numpy/_core/strings.pyi

@@ -6,7 +6,6 @@ from numpy._typing import (
     _ArrayLikeStr_co as U_co,
     _ArrayLikeBytes_co as S_co,
     _ArrayLikeInt_co as i_co,
-    _ArrayLikeBool_co as b_co,
     _ArrayLikeString_co as T_co,
     _ArrayLikeAnyString_co as UST_co,
     _Shape,