queue implementation for user registration and email verification #10
Conversation
…ate to user-service
Ifechukwu001
left a comment
Ifechukwu001
left a comment
There was a problem hiding this comment.
The whole thing is okay.
I was also thinking about the security of the broker, Mr Ebuka used hashing to hash the message, if we use that, then you need to look into a custom decoder for the RabbitMQ. or maybe a different approach of using headers.
| "faststream[rabbit]>=0.5.39", | ||
| "starlette>=0.46.2", | ||
| "uvicorn>=0.34.1", | ||
| "django-extensions>=4.1", |
There was a problem hiding this comment.
What is the use of the django extensions package?
There was a problem hiding this comment.
Please also remove the pika, It was an oversight from me, it's not a dependency again
There was a problem hiding this comment.
What is the use of the django extensions package?
It is for listing all exposed django endpoints. run as manage.py show_urls
Comes in handy especially when there's no swagger docs
src/api/services/AuthService.py
Outdated
| user, {"is_active": True, "is_enabled": True, "is_validated": True} | ||
| ) | ||
| user_data = {"id": user.id, "email": user.email} | ||
| queue = "validate-user" |
There was a problem hiding this comment.
Same magic string comment
I checked. He is not really hashing the message. Just adds a signed key, that is validated at the consumer end. Similar with what we did for request headers. Should we stick with that or do we actually encrypt the message? |
Yeah It's fine to use headers. |
1 similar comment
Yeah It's fine to use headers. |
2 participants
closes #5