-
Notifications
You must be signed in to change notification settings - Fork 0
Integrate paging for Topic Screen
#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
88c5009
Integrate multiplatform paging for `Topic Screen`
yesshreyes 8af5f62
Integrate multiplatform paging for `Topic Screen`
yesshreyes 18b2b85
- Update `TopicViewModel` to use `PagingData<TopicUi>` directly, remo…
yesshreyes 1ffffb2
- Rename `TopicUi` to `Topic` for better clarity.
yesshreyes 24f240e
Make corrections to model classes and variables
RajashekarRaju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 24 additions & 1 deletion
25
...m/developersbreach/kotlindictionarymultiplatform/data/topic/repository/TopicRepository.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,44 @@ | ||
| package com.developersbreach.kotlindictionarymultiplatform.data.topic.repository | ||
|
|
||
| import arrow.core.Either | ||
| import arrow.core.getOrElse | ||
| import com.developersbreach.kotlindictionarymultiplatform.data.topic.model.TopicResponse | ||
| import com.developersbreach.kotlindictionarymultiplatform.data.topic.model.Topic | ||
| import com.developersbreach.kotlindictionarymultiplatform.data.topic.model.toTopic | ||
| import com.developersbreach.kotlindictionarymultiplatform.core.network.topicSource.FirestoreConstants | ||
| import com.developersbreach.kotlindictionarymultiplatform.ui.screens.topic.TopicUi | ||
| import io.ktor.client.HttpClient | ||
| import io.ktor.client.call.body | ||
| import io.ktor.client.request.get | ||
|
|
||
| class TopicRepository( | ||
| private val httpClient: HttpClient, | ||
| ) { | ||
| suspend fun getTopics(): Either<Throwable, List<Topic>> { | ||
| private suspend fun getTopics(): Either<Throwable, List<Topic>> { | ||
| return Either.catch { | ||
| val topicResponse: TopicResponse = httpClient.get(FirestoreConstants.TOPICS_URL).body() | ||
| topicResponse.topics.map { it.toTopic() } | ||
| } | ||
| } | ||
|
|
||
| suspend fun getTopicsPage( | ||
| page: Int, | ||
| pageSize: Int, | ||
| query: String, | ||
| ): List<TopicUi> { | ||
| val allTopics = getTopics().getOrElse { emptyList() } | ||
| val filteredTopics = allTopics | ||
| .filter { it.name?.contains(query, ignoreCase = true) == true } | ||
| .sortedBy { it.name?.lowercase() ?: "" } | ||
| .map { topic -> | ||
| TopicUi( | ||
| name = topic.name ?: "", | ||
| initial = topic.name?.firstOrNull()?.uppercase() ?: "", | ||
| description = topic.description ?: "", | ||
| ) | ||
| } | ||
| val fromIndex = (page - 1) * pageSize | ||
| val toIndex = (fromIndex + pageSize).coerceAtMost(filteredTopics.size) | ||
| return if (fromIndex < filteredTopics.size) filteredTopics.subList(fromIndex, toIndex) else emptyList() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
.../com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicPagingSource.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package com.developersbreach.kotlindictionarymultiplatform.ui.screens.topic | ||
|
|
||
| import app.cash.paging.PagingSource | ||
| import app.cash.paging.PagingState | ||
| import com.developersbreach.kotlindictionarymultiplatform.data.topic.repository.TopicRepository | ||
|
|
||
| class TopicPagingSource( | ||
yesshreyes marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| private val repository: TopicRepository, | ||
| private val query: String, | ||
| ) : PagingSource<Int, TopicUi>() { | ||
|
|
||
| override suspend fun load( | ||
| params: LoadParams<Int>, | ||
| ): LoadResult<Int, TopicUi> { | ||
| val page = params.key ?: 1 | ||
| val pageSize = params.loadSize | ||
| return try { | ||
| val pageItems = repository.getTopicsPage(page, pageSize, query) | ||
| LoadResult.Page( | ||
| data = pageItems, | ||
| prevKey = if (page == 1) null else page - 1, | ||
| nextKey = if (pageItems.isEmpty()) null else page + 1, | ||
| ) | ||
| } catch (e: Exception) { | ||
| LoadResult.Error(e) | ||
| } | ||
| } | ||
|
|
||
| override fun getRefreshKey( | ||
| state: PagingState<Int, TopicUi>, | ||
| ): Int { | ||
| return 1 | ||
yesshreyes marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
...ain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicUi.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.developersbreach.kotlindictionarymultiplatform.ui.screens.topic | ||
|
|
||
| data class TopicUi( | ||
yesshreyes marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| val name: String, | ||
| val initial: String, | ||
| val description: String, | ||
| ) | ||
16 changes: 0 additions & 16 deletions
16
...otlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicUiState.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.