Footer hidden on specific pages#1
Merged
Devonab merged 3 commits intoDevonab:mainfrom Jan 7, 2025
holmesadam:hidden-on-pages
Merged
Footer hidden on specific pages#1Devonab merged 3 commits intoDevonab:mainfrom holmesadam:hidden-on-pages
Devonab merged 3 commits intoDevonab:mainfrom
holmesadam:hidden-on-pages
Conversation
- Test default footer visibility - Test footer visibility on non-configured pages - Test footer hiding on configured pages
Owner
|
Thank you for your contribution 😊 |
Contributor
Author
|
Thank you! And apologies for not adding tests 🤦🏻♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin has functionality to "hide on auth pages", however, the paths set in the auth constant are not always the auth pages.
This PR allows the user to set their own array of pages to ignore the footer on (not just auth pages). See readme for methods.