Fix sidebar footer + refactor config file for PHPStan error#14
Merged
Devonab merged 3 commits intofilament-v4from Aug 6, 2025
Merged
Fix sidebar footer + refactor config file for PHPStan error#14Devonab merged 3 commits intofilament-v4from
Devonab merged 3 commits intofilament-v4from
Conversation
Deleted CSS and JS files from resources, including compiled and source assets, and updated the Blade view and service provider. This likely reflects a move away from custom asset compilation or a refactor to handle assets differently.
Updated the configuration to use null defaults instead of environment variables for 'app_name' and GitHub settings. Adjusted the README to reflect these changes and clarified configuration instructions. Modified the Blade view to fallback to 'app.name' if 'app_name' is not set in the plugin config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up the plugin for version v4.0-beta of FilamentPHP by removing unnecessary CSS and JS files and correcting the height of the footer once it is positioned in the sidebar. A refactoring is also employed here to rectify the PHPStan error and to avoid using calls to
env()in the configuration file.sidebarandsidebar.footer