Skip to content

add text to custom logo, and make custom logo url opens in new tab #6

Merged
Devonab merged 2 commits intoDevonab:mainfrom
Cybrarist:feature/add-text-to-custom-logo
Feb 26, 2025
Merged

add text to custom logo, and make custom logo url opens in new tab #6
Devonab merged 2 commits intoDevonab:mainfrom
Cybrarist:feature/add-text-to-custom-logo

Conversation

@Cybrarist
Copy link
Contributor

small break change

logo text is before height,so it will not consider the height the user has passed and it the passed height will go as the text.

we can move the text to the end, but i highly doubt height will be changed as much as text.

@Devonab Devonab self-assigned this Feb 26, 2025
@Devonab Devonab merged commit f35bc3c into Devonab:main Feb 26, 2025
9 checks passed
@Devonab
Copy link
Owner

Devonab commented Feb 26, 2025

Hi, thanks again for your contribution.
For the small breaking change, yes, but I don't think it's too much of a problem... I'll add a mention in the release note 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants