--savemesh argument in example 12 #207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12_MeshLoaders/main.cpp
Outdated
Comment on lines
213
to
214
| auto& asset = m_currentBundle.getContents()[0]; | ||
| IAssetWriter::SAssetWriteParams params{ asset.get() }; |
There was a problem hiding this comment.
only what you're intending to write shall be kept
12_MeshLoaders/main.cpp
Outdated
| auto savePath = (prefix / path(m_modelPath).filename()).generic_string(); | ||
|
|
||
| m_logger->log("Saving mesh to %S", ILogger::ELL_INFO, savePath.c_str()); | ||
| // TODO (Yas): learn how to get out the geometry from renderer and transform it into IAsset |
There was a problem hiding this comment.
you can't go from IGPUObject to ICPUObject easily
12_MeshLoaders/main.cpp
Outdated
Comment on lines
443
to
447
| // make save path | ||
| static const auto prefix = std::filesystem::absolute("saved/"); | ||
|
|
||
| if (!std::filesystem::exists(prefix)) | ||
| m_system->createDirectory(prefix); |
There was a problem hiding this comment.
path is wrong, see the 4 CWD members of the apocalypse in the basic framework app
12_MeshLoaders/main.cpp
Outdated
| @@ -197,22 +197,9 @@ class MeshLoadersApp final : public MonoWindowApplication, public BuiltinResourc | |||
|
|
|||
| inline bool onAppTerminated() override | |||
| { | |||
| if (m_saveMeshOnExit) | |||
| if (m_saveGeomOnExit) | |||
There was a problem hiding this comment.
check for current geom
12_MeshLoaders/main.cpp
Outdated
| // should I do a const cast here? | ||
| const IAsset* asset = m_currentGeom.get(); | ||
| IAssetWriter::SAssetWriteParams params{ const_cast<IAsset*>(asset) }; | ||
| m_assetMgr->writeAsset(savePath, params); |
There was a problem hiding this comment.
after writing out once, the `m_currentGeom needs to be nulled out
…hen invalid path has been selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.