Implement visitDependents

kevyuu · kevyuu · commit 165eebc56ca1 · 2025-06-11T20:34:41.000+07:00
diff --git a/include/nbl/asset/IAsset.h b/include/nbl/asset/IAsset.h
@@ -156,6 +156,25 @@ class IAsset : virtual public core::IReferenceCounted
 		//!
 		inline bool isMutable() const {return m_mutable;}
 
+		inline void visitDependents(std::function<bool(const IAsset*)> visit) const
+		{
+				visitDependentsImpl([&visit](const IAsset* dep)->bool
+        {
+            if (dep)
+                return visit(dep);
+            return true;
+        });
+		}
+
+    inline void visitDependents(std::function<bool(IAsset*)> visit)
+    {
+        assert(isMutable());
+				visitDependents([&](const IAsset* dependent) -> bool
+				{
+						return visit(const_cast<IAsset*>(dependent));
+				});
+    }
+
 		virtual core::unordered_set<const IAsset*> computeDependants() const = 0;
 
 		virtual core::unordered_set<IAsset*> computeDependants() = 0;
@@ -174,6 +193,8 @@ class IAsset : virtual public core::IReferenceCounted
 	private:
 		friend IAssetManager;
 		bool m_mutable = true;
+
+		virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const = 0;
 };
 
 template<typename T>
diff --git a/include/nbl/asset/ICPUAccelerationStructure.h b/include/nbl/asset/ICPUAccelerationStructure.h
@@ -135,6 +135,7 @@ class ICPUBottomLevelAccelerationStructure final : public IPreHashed, public IBo
 			return cp;
 		}
 
+
 		// Do not report anything as a dependant, we'll simply drop the data instead of discarding its contents
 		inline core::unordered_set<const IAsset*> computeDependants() const override
 		{
@@ -257,6 +258,8 @@ class ICPUBottomLevelAccelerationStructure final : public IPreHashed, public IBo
 		core::smart_refctd_dynamic_array<AABBs<ICPUBuffer>> m_AABBGeoms = nullptr;
 		core::smart_refctd_dynamic_array<uint32_t> m_geometryPrimitiveCount = nullptr;
 		core::bitflag<BUILD_FLAGS> m_buildFlags = BUILD_FLAGS::PREFER_FAST_TRACE_BIT;
+
+		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override {}
 };
 
 class ICPUTopLevelAccelerationStructure final : public IAsset, public ITopLevelAccelerationStructure
@@ -386,6 +389,12 @@ class ICPUTopLevelAccelerationStructure final : public IAsset, public ITopLevelA
         for (const auto& instance : *self->m_instances)
           dependants.insert(instance.getBase().blas.get());
         return dependants;
+    }
+
+		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    {
+        for (const auto& instance : *m_instances)
+            if (!visit(instance.getBase().blas.get())) return;
     }
 };
 
diff --git a/include/nbl/asset/ICPUAnimationLibrary.h b/include/nbl/asset/ICPUAnimationLibrary.h
@@ -113,6 +113,13 @@ class ICPUAnimationLibrary final : public IAnimationLibrary<ICPUBuffer>, public
     static auto computeDependantsImpl(Self* self) {
         using asset_ptr_t = std::conditional_t<std::is_const_v<Self>, const IAsset*, IAsset*>;
         return core::unordered_set<asset_ptr_t>{ self->m_keyframeStorageBinding.buffer.get(), self->m_timestampStorageBinding.buffer.get(), self->m_animationStorageRange.buffer.get() };
+    }
+
+		virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    {
+        if (!visit(m_keyframeStorageBinding.buffer.get())) return;
+        if (!visit(m_timestampStorageBinding.buffer.get())) return;
+        if (!visit(m_animationStorageRange.buffer.get())) return;
     }
 };
 
diff --git a/include/nbl/asset/ICPUBuffer.h b/include/nbl/asset/ICPUBuffer.h
@@ -139,6 +139,8 @@ class ICPUBuffer final : public asset::IBuffer, public IPreHashed
         discardContent_impl();
     }
 
+    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override {}
+
     void* m_data;
     core::smart_refctd_ptr<core::refctd_memory_resource> m_mem_resource;
     size_t m_alignment;
diff --git a/include/nbl/asset/ICPUBufferView.h b/include/nbl/asset/ICPUBufferView.h
@@ -28,6 +28,7 @@ class ICPUBufferView : public IBufferView<ICPUBuffer>, public IAsset
 		constexpr static inline auto AssetType = ET_BUFFER_VIEW;
 		inline IAsset::E_TYPE getAssetType() const override { return AssetType; }
 
+
     inline core::unordered_set<const IAsset*> computeDependants() const override
 		{
 			return computeDependantsImpl(this);
@@ -66,6 +67,11 @@ class ICPUBufferView : public IBufferView<ICPUBuffer>, public IAsset
         using asset_ptr_t = std::conditional_t<std::is_const_v<Self>, const IAsset*, IAsset*>;
         return core::unordered_set<asset_ptr_t>{ self->m_buffer.get() };
     }
+
+		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+		{
+        if (!visit(m_buffer.get())) return;
+		}
 };
 
 }
diff --git a/include/nbl/asset/ICPUComputePipeline.h b/include/nbl/asset/ICPUComputePipeline.h
@@ -105,6 +105,12 @@ class ICPUComputePipeline final : public ICPUPipeline<IComputePipeline<ICPUPipel
             using asset_ptr_t = std::conditional_t<std::is_const_v<Self>, const IAsset*, IAsset*>;
             return core::unordered_set<asset_ptr_t>{ self->m_layout.get(), self->m_specInfo.shader.get() };
         }
+        
+        virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        {
+            if (!visit(m_layout.get())) return;
+            if (!visit(m_specInfo.shader.get())) return;
+        }
 };
 
 }
diff --git a/include/nbl/asset/ICPUDescriptorSet.h b/include/nbl/asset/ICPUDescriptorSet.h
@@ -127,6 +127,35 @@ class NBL_API2 ICPUDescriptorSet final : public IDescriptorSet<ICPUDescriptorSet
         }
         return dependants;
     }
+
+    virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    {
+        for (auto i = 0u; i < static_cast<uint32_t>(IDescriptor::E_TYPE::ET_COUNT); i++)
+        {
+          if (!m_descriptorInfos[i]) continue;
+          const auto size = m_descriptorInfos[i]->size();
+          for (auto desc_i = 0u; desc_i < size; desc_i++)
+          {
+            auto* desc = m_descriptorInfos[i]->operator[](desc_i).desc.get();
+            if (!desc) continue;
+            switch (IDescriptor::GetTypeCategory(static_cast<IDescriptor::E_TYPE>(i)))
+            {
+            case IDescriptor::EC_BUFFER:
+              if (!visit(static_cast<const ICPUBuffer*>(desc))) return;
+            case IDescriptor::EC_SAMPLER:
+              if (!visit(static_cast<const ICPUSampler*>(desc))) return;
+            case IDescriptor::EC_IMAGE:
+              if (!visit(static_cast<const ICPUImageView*>(desc))) return;
+            case IDescriptor::EC_BUFFER_VIEW:
+              if (!visit(static_cast<ICPUBufferView*>(desc))) return;
+            case IDescriptor::EC_ACCELERATION_STRUCTURE:
+              if (!visit(static_cast<ICPUTopLevelAccelerationStructure*>(desc))) return;
+            default:
+              break;
+            }
+          }
+        }
+    }
 };
 
 }
diff --git a/include/nbl/asset/ICPUDescriptorSetLayout.h b/include/nbl/asset/ICPUDescriptorSetLayout.h
@@ -85,6 +85,12 @@ class ICPUDescriptorSetLayout : public IDescriptorSetLayout<ICPUSampler>, public
           return dependants;
       }
 
+      inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+      {
+          if (m_immutableSamplers) return;
+          for (const auto& sampler : *m_immutableSamplers)
+              if (!visit(sampler.get())) return;
+      }
 };
 
 }
diff --git a/include/nbl/asset/ICPUGraphicsPipeline.h b/include/nbl/asset/ICPUGraphicsPipeline.h
@@ -146,6 +146,14 @@ class ICPUGraphicsPipeline final : public ICPUPipeline<IGraphicsPipeline<ICPUPip
 
             return core::smart_refctd_ptr<base_t>(newPipeline, core::dont_grab);
         }
+
+        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        {
+            if (!visit(m_layout.get())) return;
+            if (!visit(m_renderpass.get())) return;
+            for (const auto& info : m_specInfos)
+              if (!visit(info.shader.get())) return;
+        }
 };
 
 }
diff --git a/include/nbl/asset/ICPUImage.h b/include/nbl/asset/ICPUImage.h
@@ -227,6 +227,10 @@ class NBL_API2 ICPUImage final : public IImage, public IPreHashed
 				return _a.imageSubresource.mipLevel < _b.imageSubresource.mipLevel;
 			}
 		};
+
+    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    {
+    }
 };
 
 } // end namespace nbl::asset
diff --git a/include/nbl/asset/ICPUImageView.h b/include/nbl/asset/ICPUImageView.h
@@ -82,6 +82,11 @@ class ICPUImageView final : public IImageView<ICPUImage>, public IAsset
         using asset_ptr_t = std::conditional_t<std::is_const_v<Self>, const IAsset*, IAsset*>;
         return core::unordered_set<asset_ptr_t>{ self->params.image.get() };
     }
+
+    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    {
+        if (!visit(params.image.get())) return;
+    }
 };
 
 }
diff --git a/include/nbl/asset/ICPUMesh.h b/include/nbl/asset/ICPUMesh.h
@@ -96,6 +96,10 @@ class ICPUMesh final : public IMesh<ICPUMeshBuffer>, public IAsset
 
 	private:
 		core::vector<core::smart_refctd_ptr<ICPUMeshBuffer>> m_meshBuffers;
+
+        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        {
+        }
 };
 
 }
diff --git a/include/nbl/asset/ICPUMeshBuffer.h b/include/nbl/asset/ICPUMeshBuffer.h
@@ -622,6 +622,9 @@ class ICPUMeshBuffer final : public IMeshBuffer<ICPUBuffer,ICPUDescriptorSet,ICP
             return {};
         }
 
+        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        {
+        }
 };
 
 }
diff --git a/include/nbl/asset/ICPUPipelineCache.h b/include/nbl/asset/ICPUPipelineCache.h
@@ -60,12 +60,12 @@ class ICPUPipelineCache final : public IPreHashed
 			return core::make_smart_refctd_ptr<ICPUPipelineCache>(std::move(cache_cp));
 		}
 
-	  inline core::unordered_set<const IAsset*> computeDependants() const override
+		inline core::unordered_set<const IAsset*> computeDependants() const override
 		{
 			return {};
 		}
 
-	  inline core::unordered_set<IAsset*> computeDependants() override
+		inline core::unordered_set<IAsset*> computeDependants() override
 		{
 			return {};
 		}
@@ -102,6 +102,10 @@ class ICPUPipelineCache final : public IPreHashed
 
 	private:
 		entries_map_t m_cache;
+
+		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+		{
+		}
 };
 
 }
diff --git a/include/nbl/asset/ICPUPipelineLayout.h b/include/nbl/asset/ICPUPipelineLayout.h
@@ -92,6 +92,15 @@ class ICPUPipelineLayout : public IAsset, public IPipelineLayout<ICPUDescriptorS
           return dependants;
       }
 
+      inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+      {
+          for (auto i = 0; i < m_descSetLayouts.size(); i++)
+          {
+              if (m_descSetLayouts[i]) continue;
+              if (!visit(m_descSetLayouts[i].get())) return;
+          }
+      }
+
 };
 
 }
diff --git a/include/nbl/asset/ICPURayTracingPipeline.h b/include/nbl/asset/ICPURayTracingPipeline.h
@@ -138,6 +138,23 @@ class ICPURayTracingPipeline final : public ICPUPipeline<IRayTracingPipeline<ICP
             return dependants;
         }
 
+        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        {
+            core::unordered_set<const IAsset*> dependants;
+            const auto visitOnce = [&](const IAsset* dep) -> bool {
+                auto [iter, inserted] = dependants.insert(dep);
+                if (inserted) return visit(dep);
+                return true;
+            };
+            visitOnce(m_raygen.shader.get());
+            for (const auto& missInfo : self->m_misses) visitOnce(missInfo.shader.get());
+            for (const auto& anyHitInfo : self->m_hitGroups.anyHits) visitOnce(anyHitInfo.shader.get());
+            for (const auto& closestHitInfo : self->m_hitGroups.closestHits) visitOnce(closestHitInfo.shader.get());
+            for (const auto& intersectionInfo : self->m_hitGroups.intersections) visitOnce(intersectionInfo.shader.get());
+            for (const auto& callableInfo : self->m_callables) visitOnce(callableInfo.shader.get());
+
+        }
+
         inline core::smart_refctd_ptr<base_t> clone_impl(core::smart_refctd_ptr<ICPUPipelineLayout>&& layout, uint32_t depth) const override final
         {
             auto newPipeline = new ICPURayTracingPipeline(layout.get());
diff --git a/include/nbl/asset/ICPURenderpass.h b/include/nbl/asset/ICPURenderpass.h
@@ -52,6 +52,12 @@ class ICPURenderpass : public IRenderpass, public IAsset
         inline ICPURenderpass(const SCreationParams& _params, const SCreationParamValidationResult& _validation) : IRenderpass(_params, _validation) {}
         inline ~ICPURenderpass() = default;
 
+    private:
+
+        inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+        {
+        }
+
 };
 
 }
diff --git a/include/nbl/asset/ICPURenderpassIndependentPipeline.h b/include/nbl/asset/ICPURenderpassIndependentPipeline.h
@@ -157,6 +157,12 @@ class ICPURenderpassIndependentPipeline : public IRenderpassIndependentPipeline,
 		std::array<std::unique_ptr<IPipelineBase::SShaderSpecInfo::spec_constant_map_t>,GRAPHICS_SHADER_STAGE_COUNT> m_entries = {};
 		std::array<IPipelineBase::SShaderSpecInfo,GRAPHICS_SHADER_STAGE_COUNT> m_infos = {};
 #endif
+
+  private:
+
+    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    {
+    }
 };
 
 }
diff --git a/include/nbl/asset/ICPUSampler.h b/include/nbl/asset/ICPUSampler.h
@@ -78,6 +78,12 @@ class ICPUSampler : public ISampler, public IAsset
 		{
         return {};
 		}
+
+  private:
+
+    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    {
+    }
 };
 
 }
diff --git a/include/nbl/asset/ICPUSkeleton.h b/include/nbl/asset/ICPUSkeleton.h
@@ -96,6 +96,12 @@ class ICPUSkeleton final : public ISkeleton<ICPUBuffer>, public IAsset
         using asset_ptr_t = std::conditional_t<std::is_const_v<Self>, const IAsset*, IAsset*>;
         return core::unordered_set<asset_ptr_t>{ self->m_defaultTransforms.buffer.get(), self->m_parentJointIDs.buffer.get() };
     }
+
+		inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+		{
+        if (!visit(m_defaultTransforms.buffer.get())) return;
+				if (!visit(m_parentJointIDs.buffer.get())) return;
+		}
 };
 
 }
diff --git a/include/nbl/asset/IShader.h b/include/nbl/asset/IShader.h
@@ -114,6 +114,11 @@ class IShader : public IAsset
         using asset_ptr_t = std::conditional_t<std::is_const_v<Self>, const IAsset*, IAsset*>;
         return core::unordered_set<asset_ptr_t>{self->m_code.get()};
     }
+
+    inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override
+    {
+        if (!visit(m_code.get())) return;
+    }
 };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,8 @@ class ICPUBuffer final : public asset::IBuffer, public IPreHashed`
`139`	`139`	`discardContent_impl();`
`140`	`140`	`}`
`141`	`141`
	`142`	`+ inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override {}`
	`143`	`+`
`142`	`144`	`void* m_data;`
`143`	`145`	`core::smart_refctd_ptr<core::refctd_memory_resource> m_mem_resource;`
`144`	`146`	`size_t m_alignment;`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ class ICPUBufferView : public IBufferView<ICPUBuffer>, public IAsset`
`28`	`28`	`constexpr static inline auto AssetType = ET_BUFFER_VIEW;`
`29`	`29`	`inline IAsset::E_TYPE getAssetType() const override { return AssetType; }`
`30`	`30`
	`31`	`+`
`31`	`32`	`inline core::unordered_set<const IAsset*> computeDependants() const override`
`32`	`33`	`{`
`33`	`34`	`return computeDependantsImpl(this);`
`@@ -66,6 +67,11 @@ class ICPUBufferView : public IBufferView<ICPUBuffer>, public IAsset`
`66`	`67`	`using asset_ptr_t = std::conditional_t<std::is_const_v<Self>, const IAsset, IAsset>;`
`67`	`68`	`return core::unordered_set<asset_ptr_t>{ self->m_buffer.get() };`
`68`	`69`	`}`
	`70`	`+`
	`71`	`+ inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`72`	`+ {`
	`73`	`+ if (!visit(m_buffer.get())) return;`
	`74`	`+ }`
`69`	`75`	`};`
`70`	`76`
`71`	`77`	`}`
Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,12 @@ class ICPUComputePipeline final : public ICPUPipeline<IComputePipeline<ICPUPipel`
`105`	`105`	`using asset_ptr_t = std::conditional_t<std::is_const_v<Self>, const IAsset, IAsset>;`
`106`	`106`	`return core::unordered_set<asset_ptr_t>{ self->m_layout.get(), self->m_specInfo.shader.get() };`
`107`	`107`	`}`
	`108`	`+`
	`109`	`+ virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`110`	`+ {`
	`111`	`+ if (!visit(m_layout.get())) return;`
	`112`	`+ if (!visit(m_specInfo.shader.get())) return;`
	`113`	`+ }`
`108`	`114`	`};`
`109`	`115`
`110`	`116`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,12 @@ class ICPUDescriptorSetLayout : public IDescriptorSetLayout<ICPUSampler>, public`
`85`	`85`	`return dependants;`
`86`	`86`	`}`
`87`	`87`
	`88`	`+ inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`89`	`+ {`
	`90`	`+ if (m_immutableSamplers) return;`
	`91`	`+ for (const auto& sampler : *m_immutableSamplers)`
	`92`	`+ if (!visit(sampler.get())) return;`
	`93`	`+ }`
`88`	`94`	`};`
`89`	`95`
`90`	`96`	`}`
Original file line number	Diff line number	Diff line change
`@@ -146,6 +146,14 @@ class ICPUGraphicsPipeline final : public ICPUPipeline<IGraphicsPipeline<ICPUPip`
`146`	`146`
`147`	`147`	`return core::smart_refctd_ptr<base_t>(newPipeline, core::dont_grab);`
`148`	`148`	`}`
	`149`	`+`
	`150`	`+ inline virtual void visitDependentsImpl(std::function<bool(const IAsset*)> visit) const override`
	`151`	`+ {`
	`152`	`+ if (!visit(m_layout.get())) return;`
	`153`	`+ if (!visit(m_renderpass.get())) return;`
	`154`	`+ for (const auto& info : m_specInfos)`
	`155`	`+ if (!visit(info.shader.get())) return;`
	`156`	`+ }`
`149`	`157`	`};`
`150`	`158`
`151`	`159`	`}`