we are getting closer, fix temporary object reference by a pointer, don't log on android build in openEXR loader

Author: AnastaZIuk

examples_tests/43.SumAndCDFFilters/main.cpp

@@ -68,9 +68,9 @@ class SumAndCDFFilterSampleApp : public NonGraphicalApplicationBase
 
 public:
 
-	void setSystem(core::smart_refctd_ptr<nbl::system::ISystem>&& system) override
+	void setSystem(core::smart_refctd_ptr<nbl::system::ISystem>&& _system) override
 	{
-		system = std::move(system);
+		system = std::move(_system);
 	}
 
 	NON_GRAPHICAL_APP_CONSTRUCTOR(SumAndCDFFilterSampleApp);

src/nbl/CMakeLists.txt

@@ -122,8 +122,6 @@ option(_NBL_COMPILE_WITH_GLTF_LOADER_ "Compile with GLTF Loader" ON)
 option(_NBL_COMPILE_WITH_GLTF_WRITER_ "Compile with GLTF Writer" ON)
 
 if(NBL_BUILD_ANDROID)
-	# TODO - remove those bellow in future
-	set(_NBL_COMPILE_WITH_OPEN_EXR_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE) 		# TODO - check it out
 	set(_NBL_COMPILE_WITH_BAW_LOADER_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE)	# TODO - remove when BAW-v4 is done
 	set(_NBL_COMPILE_WITH_BAW_WRITER_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE)	# TODO - remove when BAW-v4 is done
 	set(_NBL_COMPILE_WITH_OBJ_LOADER_ OFF CACHE BOOL "Off for Android purposes at the moment" FORCE)

src/nbl/asset/interchange/CImageLoaderOpenEXR.cpp

@@ -356,7 +356,9 @@ namespace nbl
 
 					if (params.format == EF_UNKNOWN)
 					{
+						#ifndef  _NBL_PLATFORM_ANDROID_
 						_params.logger.log("LOAD EXR: incorrect format specified for " + suffixOfChannels + " channels - skipping the file %s", system::ILogger::ELL_INFO, file.fileName());
+						#endif // ! _NBL_PLATFORM_ANDROID_
 						continue;
 					}
 
@@ -463,6 +465,7 @@ namespace nbl
 			const auto bChannel = doesTheChannelExist("B", mapOfChannels);
 			const auto aChannel = doesTheChannelExist("A", mapOfChannels);
 
+			#ifndef _NBL_PLATFORM_ANDROID_
 			if (rChannel && gChannel && bChannel && aChannel)
 				logger.log("LOAD EXR: loading " + suffixName + " RGBA file %s", system::ILogger::ELL_INFO, fileName.c_str());
 			else if (rChannel && gChannel && bChannel)
@@ -473,6 +476,7 @@ namespace nbl
 				logger.log("LOAD EXR: loading " + suffixName + " R file %s", system::ILogger::ELL_INFO, fileName.c_str());
 			else 
 				logger.log("LOAD EXR: the file's channels are invalid to load %s", system::ILogger::ELL_ERROR, fileName.c_str());
+			#endif // ! _NBL_PLATFORM_ANDROID_
 
 			auto doesMapOfChannelsFormatHaveTheSameFormatLikePassedToIt = [&](const PixelType ImfTypeToCompare)
 			{
@@ -521,7 +525,9 @@ namespace nbl
 				if (isTheBitActive(9))
 				{
 					versionField.Compoment.singlePartFileCompomentSubTypes = SContext::VersionField::Compoment::TILES;
+					#ifndef _NBL_PLATFORM_ANDROID_
 					logger.log("LOAD EXR: the file consist of not supported tiles %s", system::ILogger::ELL_ERROR, file.fileName());
+					#endif // !_NBL_PLATFORM_ANDROID_
 					return false;
 				}
 				else
@@ -531,14 +537,18 @@ namespace nbl
 			{
 				versionField.Compoment.type = SContext::VersionField::Compoment::MULTI_PART_FILE;
 				versionField.Compoment.singlePartFileCompomentSubTypes = SContext::VersionField::Compoment::SCAN_LINES_OR_TILES;
+				#ifndef  _NBL_PLATFORM_ANDROID_
 				logger.log("LOAD EXR: the file is a not supported multi part file %s", system::ILogger::ELL_ERROR, file.fileName());
+				#endif // ! _NBL_PLATFORM_ANDROID_
 				return false;
 			}
 
 			if (!isTheBitActive(9) && isTheBitActive(11) && isTheBitActive(12))
 			{
 				versionField.doesItSupportDeepData = true;
+				#ifndef  _NBL_PLATFORM_ANDROID_
 				logger.log("LOAD EXR: the file consist of not supported deep data%s", system::ILogger::ELL_ERROR, file.fileName());
+				#endif // ! _NBL_PLATFORM_ANDROID_
 				return false;
 			}
 			else

src/nbl/system/CFilePOSIX.cpp

@@ -12,7 +12,8 @@ namespace nbl::system
 	CFilePOSIX::CFilePOSIX(core::smart_refctd_ptr<ISystem>&& sys, const std::filesystem::path& _filename, core::bitflag<E_CREATE_FLAGS> _flags) :
 		base_t(std::move(sys), _filename, _flags)
 	{
-		const char* name_c_str = _filename.string().c_str();
+		auto filenameStream = _filename.string();
+		const char* name_c_str = filenameStream.c_str();
 		int createFlags = O_LARGEFILE;
 		int mappingFlags;
 		if ((_flags.value & ECF_READ_WRITE) == ECF_READ_WRITE)