Skip to content

Commit 99a3cb5

Browse files
Upgrade SPV default target to 1.6
Also test examples 1-4 and update the example matrix
1 parent 3fe4a35 commit 99a3cb5

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

examples_tests/Readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ N = No support
3333
| | Win32 OpenGL | Win32 OpenGL ES* | Win32 Vulkan | X11** OpenGL | X11** OpenGL ES | X11** Vulkan | Android OpenGL ES | Android Vulkan | Required CMake Options**** |
3434
|---------------------------------|--------------|------------------|--------------|--------------|-----------------|--------------|-------------------|----------------|---------------------------------------------------|
3535
| 01.HelloWorld | Y | Y | Y | S | S | S | Y | S | |
36-
| 02.ComputeShader | B | B | Y | B | B | S | B | S | |
37-
| 03.GPU_Mesh | S | S | S | S | S | S | S | S | |
36+
| 02.ComputeShader | Y | Y | Y | B | B | S | B | S | |
37+
| 03.GPU_Mesh | W | W | W | W | W | W | W | W | |
3838
| 04.Keyframe | S | S | S | S | S | S | S | S | |
3939
| 05.NablaTutorialExample | Y | Y | Y | S | S | S | S | S | |
4040
| 06.MeshLoaders | Y | Y | Y | S | S | S | Y | Y | |

include/nbl/asset/utils/IGLSLCompiler.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class IGLSLCompiler final : public core::IReferenceCounted
4848
bool _genDebugInfo = true,
4949
std::string* _outAssembly = nullptr,
5050
system::logger_opt_ptr logger = nullptr,
51-
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_5) const;
51+
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_6) const;
5252

5353
/**
5454
If _stage is ESS_UNKNOWN, then compiler will try to deduce shader stage from #pragma annotation, i.e.:
@@ -80,7 +80,7 @@ class IGLSLCompiler final : public core::IReferenceCounted
8080
bool _genDebugInfo = true,
8181
std::string* _outAssembly = nullptr,
8282
system::logger_opt_ptr logger = nullptr,
83-
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_5) const;
83+
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_6) const;
8484

8585
core::smart_refctd_ptr<ICPUShader> createSPIRVFromGLSL(
8686
system::IFile* _sourcefile,
@@ -91,7 +91,7 @@ class IGLSLCompiler final : public core::IReferenceCounted
9191
bool _genDebugInfo = true,
9292
std::string* _outAssembly = nullptr,
9393
system::logger_opt_ptr logger = nullptr,
94-
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_5) const;
94+
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_6) const;
9595

9696
/**
9797
Resolves ALL #include directives regardless of any other preprocessor directive.
@@ -113,15 +113,15 @@ class IGLSLCompiler final : public core::IReferenceCounted
113113
const char* _originFilepath,
114114
uint32_t _maxSelfInclusionCnt = 4u,
115115
system::logger_opt_ptr logger = nullptr,
116-
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_5) const;
116+
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_6) const;
117117

118118
core::smart_refctd_ptr<ICPUShader> resolveIncludeDirectives(
119119
system::IFile* _sourcefile,
120120
IShader::E_SHADER_STAGE _stage,
121121
const char* _originFilepath,
122122
uint32_t _maxSelfInclusionCnt = 4u,
123123
system::logger_opt_ptr logger = nullptr,
124-
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_5) const;
124+
const E_SPIRV_VERSION targetSpirvVersion = ESV_1_6) const;
125125

126126
/*
127127
Creates a formatted copy of the original

src/nbl/video/CVulkanPhysicalDevice.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ class CVulkanPhysicalDevice final : public IPhysicalDevice
106106
m_limits.spirvVersion = asset::IGLSLCompiler::ESV_1_5;
107107
break;
108108
case 3:
109-
m_limits.spirvVersion = asset::IGLSLCompiler::ESV_1_5; // TODO: change this to spirv 1.6
109+
m_limits.spirvVersion = asset::IGLSLCompiler::ESV_1_6;
110110
break;
111111
default:
112112
_NBL_DEBUG_BREAK_IF("Invalid Vulkan minor version!");

src/nbl/video/IOpenGL_PhysicalDeviceBase.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ class IOpenGL_PhysicalDeviceBase : public IOpenGLPhysicalDeviceBase
493493

494494
m_limits.nonCoherentAtomSize = 256ull;
495495

496-
m_limits.spirvVersion = asset::IGLSLCompiler::ESV_1_5;
496+
m_limits.spirvVersion = asset::IGLSLCompiler::ESV_1_6;
497497

498498
if (m_glfeatures.isFeatureAvailable(COpenGLFeatureMap::NBL_KHR_shader_subgroup))
499499
{

0 commit comments

Comments
 (0)