Remove virtual on IShader::valid and IShader::visitDependents_impl

kevyuu · kevyuu · commit e2f7b8f59e50 · 2025-06-16T17:59:39.000+07:00
diff --git a/include/nbl/asset/IShader.h b/include/nbl/asset/IShader.h
@@ -87,7 +87,7 @@ class IShader : public IAsset
 
 		// TODO: `void setContent(core::smart_refctd_ptr<const ICPUBuffer>&&,const E_CONTENT_TYPE)`
 
-		inline virtual bool valid() const override
+		inline bool valid() const override
 		{
 			if (!m_code) return false;
 			if (m_contentType == E_CONTENT_TYPE::ECT_UNKNOWN) return false;
@@ -106,7 +106,7 @@ class IShader : public IAsset
 
   private:
 
-    inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
+    inline void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override
     {
         if (!visit(m_code.get())) return;
     }

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ class IShader : public IAsset`
`87`	`87`
`88`	`88`	// TODO: `void setContent(core::smart_refctd_ptr<const ICPUBuffer>&&,const E_CONTENT_TYPE)`
`89`	`89`
`90`		`- inline virtual bool valid() const override`
	`90`	`+ inline bool valid() const override`
`91`	`91`	`{`
`92`	`92`	`if (!m_code) return false;`
`93`	`93`	`if (m_contentType == E_CONTENT_TYPE::ECT_UNKNOWN) return false;`
`@@ -106,7 +106,7 @@ class IShader : public IAsset`
`106`	`106`
`107`	`107`	`private:`
`108`	`108`
`109`		`- inline virtual void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override`
	`109`	`+ inline void visitDependents_impl(std::function<bool(const IAsset*)> visit) const override`
`110`	`110`	`{`
`111`	`111`	`if (!visit(m_code.get())) return;`
`112`	`112`	`}`