Skip to content

Make STL loader/writer and PLY writer work again #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
c19ff9e
enable STL loader and writer in CMake
YasInvolved Jul 12, 2025
549ada6
enable PLY writer too
YasInvolved Jul 12, 2025
5e6316d
comment out initialize function for further inspection, implement mis…
YasInvolved Jul 14, 2025
f522af5
move SContext to .cpp and implement utility functions that used it in…
YasInvolved Jul 14, 2025
0f67f88
Merge branch 'master' of github.com:Devsh-Graphics-Programming/Nabla …
YasInvolved Jul 19, 2025
80ad67f
default off PLY and STL writers for now, fix CSTLMeshLoader initializ…
YasInvolved Jul 20, 2025
84279e5
Merge branch 'master' of github.com:Devsh-Graphics-Programming/Nabla …
YasInvolved Jul 23, 2025
1860005
Merge branch 'master' of github.com:Devsh-Graphics-Programming/Nabla …
YasInvolved Jul 29, 2025
554897d
use types from hlsl namespace
YasInvolved Jul 29, 2025
a8728a8
position and normal views
YasInvolved Jul 30, 2025
75576af
put missing TODO
YasInvolved Jul 30, 2025
d4e6745
make STL loader work
YasInvolved Jul 30, 2025
c227b70
get colors working?
YasInvolved Jul 31, 2025
5eef9a9
calculate normal if not present
YasInvolved Jul 31, 2025
45ed81d
remove lzma files pushed by accident
YasInvolved Jul 31, 2025
b3bf45d
enable STL loader
YasInvolved Jul 31, 2025
c3140ea
disable some old code to make STL writer compile
YasInvolved Jul 31, 2025
f670252
STL binary data writer
YasInvolved Jul 31, 2025
d3a01ae
delete implemented stuff from disabled code, modify todos
YasInvolved Jul 31, 2025
11d315c
detect IndexType
YasInvolved Jul 31, 2025
52a669d
reuse success variable instead of creating a new one all the time
YasInvolved Jul 31, 2025
252c92c
rework ascii writer code, add type aliases to save some typing
YasInvolved Jul 31, 2025
feabf3a
use different examples branch, success variable can't actually be reused
YasInvolved Aug 5, 2025
da2fe3e
fix NaN normals
YasInvolved Aug 6, 2025
7b9e906
comment vertex color code instead of disabling it
YasInvolved Aug 6, 2025
9602989
stop reusing success variable across the whole file, update header te…
YasInvolved Aug 6, 2025
f59ea88
don't assume index type in binary writer, fix mistake
YasInvolved Aug 6, 2025
e890923
reenable PLY writer, correct function implementations
YasInvolved Aug 6, 2025
e73b0bd
get it compiling, write a basic ply header
YasInvolved Aug 6, 2025
e608929
correct mistake in normal writing
YasInvolved Aug 13, 2025
5576403
make ply loader recognize uint and uint32 types
YasInvolved Aug 13, 2025
1f1fa06
write ply header
YasInvolved Aug 13, 2025
1e43823
basic rewrite of ply text content writing function
YasInvolved Aug 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/nbl/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ include(common)
option(_NBL_COMPILE_WITH_MTL_LOADER_ "Compile with MTL Loader" OFF) #default off until Material Compiler 2
option(_NBL_COMPILE_WITH_OBJ_LOADER_ "Compile with OBJ Loader" OFF) #default off until Material Compiler 2
#option(_NBL_COMPILE_WITH_OBJ_WRITER_ "Compile with OBJ Writer" ON) uncomment when writer exists
option(_NBL_COMPILE_WITH_STL_LOADER_ "Compile with STL Loader" OFF) #default off until reimplemented
option(_NBL_COMPILE_WITH_STL_WRITER_ "Compile with STL Writer" OFF) #default off until reimplemented
option(_NBL_COMPILE_WITH_STL_LOADER_ "Compile with STL Loader" ON)
option(_NBL_COMPILE_WITH_STL_WRITER_ "Compile with STL Writer" ON)
option(_NBL_COMPILE_WITH_PLY_LOADER_ "Compile with PLY Loader" ON)
option(_NBL_COMPILE_WITH_PLY_WRITER_ "Compile with PLY Writer" OFF) #default off until reimplemented
option(_NBL_COMPILE_WITH_PLY_WRITER_ "Compile with PLY Writer" ON) #default off until reimplemented
option(_NBL_COMPILE_WITH_JPG_LOADER_ "Compile with JPG Loader" ON)
option(_NBL_COMPILE_WITH_JPG_WRITER_ "Compile with JPG Writer" ON)
option(_NBL_COMPILE_WITH_PNG_LOADER_ "Compile with PNG Loader" ON)
Expand Down
Loading
Loading