Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new downloadable robot asset dataset entry for the ARX5 robot so it can be retrieved/extracted via the existing EmbodiChainDataset / get_data_path mechanism.
Changes:
- Add
ARX5dataset class with Open3DDataDescriptor(URL + MD5) forARX5.zip. - Document expected directory structure and usage in the class docstring.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Example usage: | ||
| >>> from embodichain.data.robot_dataset import ARX5 | ||
| >>> dataset = ARX5() | ||
| or |
There was a problem hiding this comment.
The docstring example imports ARX5 from embodichain.data.robot_dataset, but there is no embodichain/data/robot_dataset.py module in this repo (only embodichain.data.assets.* and embodichain.data.dataset). This example will raise ModuleNotFoundError; update the example to import from the actual public module path you intend to support (and consider aligning the other robot asset docstrings as well).
| def __init__(self, data_root: str = None): | ||
| data_descriptor = o3d.data.DataDescriptor( | ||
| os.path.join(EMBODICHAIN_DOWNLOAD_PREFIX, robot_assets, "ARX5.zip"), | ||
| "da207ba65e21577aa8e8f349af63e608", | ||
| ) | ||
| prefix = "ARX5" | ||
| path = EMBODICHAIN_DEFAULT_DATA_ROOT if data_root is None else data_root | ||
|
|
||
| super().__init__(prefix, data_descriptor, path) |
There was a problem hiding this comment.
PR description/checklist claims tests were added, but there are no new/updated tests covering the new ARX5 dataset class (and no references to ARX5 under tests/). Either add a small test that exercises get_data_path("ARX5/X5A.urdf") (consistent with existing tests that use get_data_path for other robots) or update the checklist to reflect the current state.
2 participants
Description
Add ARX5 robot to robot assets.
Type of change
Checklist
black .command to format the code base.