Refactor duplicated code in solver modules #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidates duplicated code patterns across kinematics solver modules into shared utility functions.
Changes:
_get_tcp_as_numpy()helper toSolverCfgbase class, used by all 6 solver configsbuild_reduced_pinocchio_robot()tosolver_utils.py, replacing duplicate_get_reduce_robot()inPinocchioSolverandPinkSolvervalidate_iteration_params()utility, shared byPinocchioSolverandPytorchSolvercompute_pinocchio_fk()utility, replacing duplicate_get_fk()implementationsType of change
Screenshots
N/A - refactoring with no functional changes
Checklist
black .command to format the code base.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.