Skip to content

Conversation

@DhruvSrivastavaX
Copy link
Owner

Changes in DYLD and ProcessAIXCore needed in reference to this PR in the community,
as it caused build failures:

@github-actions
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff origin/main HEAD --extensions cpp -- lldb/source/Plugins/DynamicLoader/AIX-DYLD/DynamicLoaderAIXDYLD.cpp lldb/source/Plugins/Process/aix-core/ProcessAIXCore.cpp --diff_from_common_commit

⚠️
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing origin/main to the base branch/commit you want to compare against.
⚠️

View the diff from clang-format here.
diff --git a/lldb/source/Plugins/Process/aix-core/ProcessAIXCore.cpp b/lldb/source/Plugins/Process/aix-core/ProcessAIXCore.cpp
index 29adfabb5..aae0992a5 100644
--- a/lldb/source/Plugins/Process/aix-core/ProcessAIXCore.cpp
+++ b/lldb/source/Plugins/Process/aix-core/ProcessAIXCore.cpp
@@ -165,8 +165,8 @@ bool ProcessAIXCore::CanDebug(lldb::TargetSP target_sp,
     if (!m_core_module_sp && FileSystem::Instance().Exists(m_core_file)) {
         ModuleSpec core_module_spec(m_core_file, target_sp->GetArchitecture());
         core_module_spec.SetTarget(target_sp);
-        Status error(ModuleList::GetSharedModule(core_module_spec, m_core_module_sp,
-                                                 nullptr, nullptr));
+        Status error(ModuleList::GetSharedModule(
+            core_module_spec, m_core_module_sp, nullptr, nullptr));
         if (m_core_module_sp) {
             ObjectFile *core_objfile = m_core_module_sp->GetObjectFile();
             if (core_objfile && core_objfile->GetType() == ObjectFile::eTypeCoreFile){

@DhruvSrivastavaX DhruvSrivastavaX merged commit 2ab7bfc into gh-101657 Nov 11, 2025
6 of 7 checks passed
@DhruvSrivastavaX DhruvSrivastavaX deleted the merge-b-11nov25 branch November 12, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants