-
Notifications
You must be signed in to change notification settings - Fork 6
Replace Handler with AttributeIO / AttributeIORef #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 92.34% 92.27% -0.08%
==========================================
Files 40 42 +2
Lines 2077 2122 +45
==========================================
+ Hits 1918 1958 +40
- Misses 159 164 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1ee25c6 to
9de949c
Compare
Contributor
Author
|
Have confirmed that the tickit demo/IOC works. Got to clean up comments and squash a bit, probably want a few extra tests too. |
Co-authored-by: Gary Yendell <[email protected]>
reorder AttributeIO generic args to allow defaults
…t, look into how this interacts with first arg
fix some test pyright errors
GDYendell
reviewed
Oct 3, 2025
GDYendell
reviewed
Oct 3, 2025
GDYendell
previously approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211
all the tests are currently broken, have not fully removed handlers yet.
So far mostly copying https://github.com/GDYendell/fastcs2 with a few minor changes
super().__init__(ref)very wip