Skip to content

Conversation

@jsouter
Copy link
Contributor

@jsouter jsouter commented Sep 19, 2025

Closes #211

all the tests are currently broken, have not fully removed handlers yet.
So far mostly copying https://github.com/GDYendell/fastcs2 with a few minor changes

  • for the time being i've removed one of the generic args from AttributeIOs, I intend to recover them at some point
  • using get_args to inspect the generic args for AttributeIO to prevent having to call super().__init__(ref)
  • using TypeVar from typing_extensions which allows us to have a default value (this is nice for Attrs but might be problematic for AttributeIOs in the current implementation, will think about this a bit more)

very wip

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 94.04762% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.27%. Comparing base (9c2042a) to head (3948522).

Files with missing lines Patch % Lines
src/fastcs/attribute_io.py 85.00% 3 Missing ⚠️
src/fastcs/attributes.py 96.00% 1 Missing ⚠️
src/fastcs/backend.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   92.34%   92.27%   -0.08%     
==========================================
  Files          40       42       +2     
  Lines        2077     2122      +45     
==========================================
+ Hits         1918     1958      +40     
- Misses        159      164       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsouter
Copy link
Contributor Author

jsouter commented Sep 29, 2025

Have confirmed that the tickit demo/IOC works. Got to clean up comments and squash a bit, probably want a few extra tests too.

James Souter and others added 27 commits October 1, 2025 16:43
Co-authored-by: Gary Yendell <[email protected]>
reorder AttributeIO generic args to allow defaults
…t, look into how this interacts with first arg
GDYendell
GDYendell previously approved these changes Oct 3, 2025
@jsouter jsouter marked this pull request as ready for review October 3, 2025 09:31
@GDYendell GDYendell merged commit 79c0234 into main Oct 3, 2025
4 of 10 checks passed
@GDYendell GDYendell deleted the attribute-io branch October 3, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Handler with AttributeIO / AttributeIORef

3 participants