Skip to content

Conversation

@hyperrealist
Copy link
Contributor

@hyperrealist hyperrealist commented Sep 26, 2025

  • Refactor FastCS
  • Refactor EpicsCATransport
  • Refactor EpicsPVSTransport
  • Refactor GraphQLTransport
  • Refactor RestTransport
  • Refactor TangoTransport
  • Fix tests

Fixes #213

@GDYendell
Copy link
Contributor

Don't worry about the docs snippets for now. They can be fixed when we've finished the 3 refactor PRs.

@hyperrealist
Copy link
Contributor Author

One Epics CA test is still randomly timing out. I need to do more testing to make sure I didn't break something.

@hyperrealist hyperrealist changed the title [WIP] Merge TransportAdapter and TransportOptions Merge TransportAdapter and TransportOptions Sep 29, 2025
@hyperrealist
Copy link
Contributor Author

I found that the tests/transport/epics/ca/test_softioc_system.py::test_ioc fails 23/100 times on this branch, and 21/100 times on the main branch. I checked, and there is no statistically significant difference based on these observations, so I conclude that this PR is ready for review. @GDYendell

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just one small suggestion.

@hyperrealist
Copy link
Contributor Author

@GDYendell CR suggestions addressed.

@GDYendell GDYendell merged commit 08010b7 into DiamondLightSource:main Sep 29, 2025
6 of 10 checks passed
@hyperrealist hyperrealist deleted the add-base-transport branch September 29, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge TransportAdapter and TransportOptions into one class

2 participants