Add transport extras #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

GDYendell merged 4 commits into DiamondLightSource:main from hyperrealist:add-transport-extras

Sep 30, 2025

Contributor

hyperrealist commented Sep 29, 2025 •

edited by GDYendell

Loading

Add epics, tango, graphql, rest, all extras
~~Make test suite work with "incomplete" installs,~~ or add all transports to dev

Fixes #94

hyperrealist added 2 commits

September 29, 2025 17:32


          initial extras


          add fastcs[all] to dev extra

e1f1edf

hyperrealist changed the title ~~[WIP] Add transport extras~~ Add transport extras

hyperrealist requested a review from GDYendell

September 30, 2025 09:16

GDYendell reviewed

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

GDYendell reviewed

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

GDYendell reviewed

View reviewed changes

pyproject.toml Show resolved Hide resolved

GDYendell reviewed

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

GDYendell reviewed

View reviewed changes

pyproject.toml Show resolved Hide resolved


          add CR suggestions

19e97a9

hyperrealist requested a review from GDYendell

September 30, 2025 10:37

Contributor

GDYendell commented Sep 30, 2025

Could you fix the dist build? It is missing a dependency. I think currently import fastcs will try to import all of the transports and fail, so there needs to be some decoupling there.


          add ruamel.yaml to dependencies

5e30ece

Contributor Author

hyperrealist commented Sep 30, 2025

@GDYendell dist is building now.

GDYendell linked an issue

that may be closed by this pull request

Restructure transports to separate dependencies into extras #94

Closed

GDYendell approved these changes

View reviewed changes

GDYendell merged commit 5ceea05 into DiamondLightSource:main

6 of 10 checks passed

hyperrealist deleted the add-transport-extras branch

September 30, 2025 15:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet