Skip to content

Conversation

@hyperrealist
Copy link
Contributor

@hyperrealist hyperrealist commented Sep 30, 2025

Do not merge

This addresses #215

  • implement SubController-specific functionality in `Controller
  • replace/re-implement all SubController references with Controller
  • remove SubControllerand rebase on main
  • fix dist build issue found not introduced in this PR
  • remove SubController from docstrings gracefully

@hyperrealist
Copy link
Contributor Author

Hmm, looks like dist build is now looking for transports

@hyperrealist hyperrealist changed the title [WIP] remove SubController Remove SubController Oct 1, 2025
@hyperrealist
Copy link
Contributor Author

@GDYendell this is ready for review

@GDYendell GDYendell merged commit 58000ca into DiamondLightSource:main Oct 1, 2025
5 of 10 checks passed
@GDYendell GDYendell linked an issue Oct 1, 2025 that may be closed by this pull request
@GDYendell GDYendell mentioned this pull request Oct 1, 2025
@hyperrealist hyperrealist deleted the remove-subcontroller branch October 1, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove SubController

2 participants