Skip to content

Conversation

@evvaaaa
Copy link
Contributor

@evvaaaa evvaaaa commented Nov 18, 2024

Closes #55

@evvaaaa evvaaaa requested review from GDYendell and jsouter November 18, 2024 11:26
@evvaaaa evvaaaa force-pushed the 55-scan-tasks-should-be-stopped-cleanly-when-process-stopped branch from 771e41f to 5df6590 Compare November 18, 2024 11:29
@evvaaaa evvaaaa force-pushed the 55-scan-tasks-should-be-stopped-cleanly-when-process-stopped branch from 5df6590 to b0c21ee Compare November 18, 2024 11:30
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.54%. Comparing base (bdab4fa) to head (b0c21ee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs/backend.py 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   82.75%   82.54%   -0.22%     
==========================================
  Files          23       23              
  Lines         928      934       +6     
==========================================
+ Hits          768      771       +3     
- Misses        160      163       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsouter
Copy link
Contributor

jsouter commented Nov 18, 2024

Works okay against fastcs-eiger

@evvaaaa evvaaaa merged commit f822afa into main Nov 18, 2024
17 checks passed
@evvaaaa evvaaaa deleted the 55-scan-tasks-should-be-stopped-cleanly-when-process-stopped branch November 18, 2024 11:55
@jsouter
Copy link
Contributor

jsouter commented Nov 18, 2024

sorry I was hasty there, the scan tasks seem to take about ~5-10s to start now compared to before where it was immediate

@evvaaaa
Copy link
Contributor Author

evvaaaa commented Nov 18, 2024

@jsouter
Ah okay I'll take late lunch break and make a new PR. Is this scan tasks in tests, or on the real eiger?

@jsouter
Copy link
Contributor

jsouter commented Nov 18, 2024

Running python -m fastcs_eiger ioc <PV_PREFIX> against the tickit sim, all I did was just add a print message to the EigerController.update to see how long it takes to start spitting it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scan tasks should be stopped cleanly when process stopped

3 participants