Skip to content

81 add features to attributes and datatypes #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GDYendell merged 7 commits into from
Nov 21, 2024
Merged

81 add features to attributes and datatypes #82

GDYendell merged 7 commits into from
Nov 21, 2024

Conversation

@evvaaaa
Copy link
Contributor

@evvaaaa evvaaaa commented Nov 20, 2024

Closes #81

@evvaaaa evvaaaa self-assigned this Nov 20, 2024
@codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.46835% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.10%. Comparing base (d1fc038) to head (546934a).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs/datatypes.py 90.90% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   85.56%   86.10%   +0.54%     
==========================================
  Files          23       23              
  Lines         928      979      +51     
==========================================
+ Hits          794      843      +49     
- Misses        134      136       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@evvaaaa evvaaaa force-pushed the 81-add-features-to-attributes-and-datatypes branch 4 times, most recently from dc40932 to 8dab77e Compare November 20, 2024 10:36
GDYendell
GDYendell reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@GDYendell GDYendell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but looks good.

GDYendell
GDYendell reviewed Nov 20, 2024
View reviewed changes
@GDYendell GDYendell mentioned this pull request Nov 20, 2024
Closed
@evvaaaa evvaaaa force-pushed the 81-add-features-to-attributes-and-datatypes branch 2 times, most recently from 510e3e3 to bf61df1 Compare November 20, 2024 13:31
GDYendell
GDYendell reviewed Nov 20, 2024
View reviewed changes
GDYendell
GDYendell reviewed Nov 20, 2024
View reviewed changes
GDYendell
GDYendell reviewed Nov 20, 2024
View reviewed changes
@evvaaaa evvaaaa force-pushed the 81-add-features-to-attributes-and-datatypes branch from bf61df1 to ec8f234 Compare November 20, 2024 15:02
@evvaaaa evvaaaa requested a review from GDYendell November 20, 2024 15:05
GDYendell
GDYendell previously approved these changes Nov 20, 2024
View reviewed changes
@evvaaaa evvaaaa force-pushed the 81-add-features-to-attributes-and-datatypes branch from ec8f234 to 86aa42a Compare November 20, 2024 15:26
@evvaaaa evvaaaa requested a review from GDYendell November 20, 2024 15:32
@evvaaaa evvaaaa force-pushed the 81-add-features-to-attributes-and-datatypes branch 2 times, most recently from 80f88a3 to 406ee90 Compare November 21, 2024 08:41
@evvaaaa evvaaaa force-pushed the 81-add-features-to-attributes-and-datatypes branch from 406ee90 to a624b70 Compare November 21, 2024 08:45
@evvaaaa evvaaaa force-pushed the 81-add-features-to-attributes-and-datatypes branch from a624b70 to 546934a Compare November 21, 2024 09:06
@GDYendell GDYendell merged commit 5256be3 into main Nov 21, 2024
17 checks passed
@GDYendell GDYendell deleted the 81-add-features-to-attributes-and-datatypes branch November 21, 2024 09:15
@GDYendell GDYendell mentioned this pull request Mar 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GDYendell GDYendell GDYendell approved these changes

Assignees

@evvaaaa evvaaaa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add features to Attributes and DataTypes

3 participants

@evvaaaa @GDYendell