Change how we search for attributes

[evvaaaa]

Closes #89

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (35b1870) to head (f45ac5c).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   87.60%   87.75%   +0.14%     
==========================================
  Files          28       28              
  Lines        1170     1184      +14     
==========================================
+ Hits         1025     1039      +14     
  Misses        145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[evvaaaa]

Will make this a draft while I write docs and make branches on eiger and odin.

[GDYendell]

I think it might be nicer to add these attributes to an _attributes member dict in __init__ rather than have a getter and then manually adding them to the member attribute on access. All the messy logic of searching through dir(), checking for clashes and filtering of root_attribute could be done in one place (_bind_attrs) instead of in Mapping.

It also occurs to me that we aren't gaining anything by making root_attribute a property, because we still have to check for "root_attribute" anyway. So, maybe it could just be a class member on SubController with default None.

Thoughts?

[evvaaaa]

I think it might be nicer to add these attributes to an _attributes member dict in init rather than have a getter

I agree this would definitely be nicer, still not containing any of the attributes defined globally in the class though.

It also occurs to me that we aren't gaining anything by making root_attribute a property, because we still have to check for "root_attribute" anyway. So, maybe it could just be a class member on SubController with default None.

Would also probably be nicer. We would still have to filter it out when searching through all the attributes on the type(controller).