Skip to content

LIMS-1605: Remove jquery-touchswipe library#895

Merged
ndg63276 merged 2 commits intopre-release/2025-R2.1from
improvement/LIMS-1605/remove-jquery-touchswipe-library
Mar 11, 2025
Merged

LIMS-1605: Remove jquery-touchswipe library#895
ndg63276 merged 2 commits intopre-release/2025-R2.1from
improvement/LIMS-1605/remove-jquery-touchswipe-library

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1605

Summary:

The jquery touchswipe plugin is out of date and only used on one page. Vanilla js can do this nowadays, so we should remove the plugin.

Changes:

  • Use the touchstart and touchend events to capture swipes
  • Remove the touchSwipe library and remove it from package.json

To test:

  • Go to proposal nt37104, go to a container
  • Check on a PC that you can move between wells by clicking on the plan of the plate
  • Switch to mobile view and refresh, check that swiping left moves to the next well, and that swiping right moves to the previous image

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R2.1 March 11, 2025 14:22
@ndg63276 ndg63276 merged commit e6ad9b0 into pre-release/2025-R2.1 Mar 11, 2025
2 checks passed
ndg63276 added a commit that referenced this pull request Mar 25, 2025
* LIMS-1646: Show 'Use Facility Account' button for EU dewar dispatch (#910)

* LIMS-1622: Add units and decimal places to visit summary page (#911)

* LIMS-1605: Remove jquery-touchswipe library (#895)

* LIMS-1496: Fix offset grid scan heatmaps in Safari (#896)

* LIMS-1389 - Add upload to ccp4 cloud button (#901)

* LIMS-538: Remove the 'Centring Method' column from creating an MX container (#908)

* LIMS-128: Add plate view to queue container page (#900)
@ndg63276 ndg63276 deleted the improvement/LIMS-1605/remove-jquery-touchswipe-library branch April 22, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants