LIMS-1389 - Add upload to ccp4 cloud button#901
Merged
ndg63276 merged 4 commits intopre-release/2025-R2.1from Mar 11, 2025
Merged
Conversation
gfrn
reviewed
Feb 24, 2025
client/src/js/views/cloudupload.js
Outdated
| upload: function() { | ||
| if (this.ui.remember.is(':checked')) { | ||
| let cookieOpts = { expires: 365, path: '/' } | ||
| $.cookie('ccp4_username', this.ui.username.val(), cookieOpts) |
Collaborator
There was a problem hiding this comment.
Could we use the native cookie management library instead, since jQuery Cookie was removed? I'm happy to do it
https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie
gfrn
approved these changes
Feb 25, 2025
Collaborator
|
Looks good! We could maybe parse the response in line 72 of |
ndg63276
added a commit
that referenced
this pull request
Mar 25, 2025
* LIMS-1646: Show 'Use Facility Account' button for EU dewar dispatch (#910) * LIMS-1622: Add units and decimal places to visit summary page (#911) * LIMS-1605: Remove jquery-touchswipe library (#895) * LIMS-1496: Fix offset grid scan heatmaps in Safari (#896) * LIMS-1389 - Add upload to ccp4 cloud button (#901) * LIMS-538: Remove the 'Centring Method' column from creating an MX container (#908) * LIMS-128: Add plate view to queue container page (#900)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1389
Summary:
We should allow users to directly send processed files (eg mtz, hkl) to CCP4 cloud, without them needing to download/upload. We can add an 'Upload to CCP4 Cloud' button to the 'attached files' dialog.
Changes:
To test: