Skip to content

LIMS-1426: Allow setting of pipeline when ranking samples#950

Merged
ndg63276 merged 3 commits intopre-release/2025-R4.2from
improvement/LIMS-1426/set-pipeline-when-ranking-samples
Sep 16, 2025
Merged

LIMS-1426: Allow setting of pipeline when ranking samples#950
ndg63276 merged 3 commits intopre-release/2025-R4.2from
improvement/LIMS-1426/set-pipeline-when-ranking-samples

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jun 25, 2025 •
edited
Loading

JIRA ticket: LIMS-1426

Summary:

When comparing well sin a plate, you can rank them by auto processing resolution or completeness, but this currently compares all processing pipelines. We should allow choosing a specific pipeline to compare like with like.

Changes:

  • Data analysis started populating the AutoProcProgram.processingPipelineId field in run 2 2025
  • Add a dropdown to the plate page, populated with the available processing pipelines
  • Pass the pipeline id into the samples query, allowing null for older analysis jobs

To test:

  • Go to proposal nt37104, and to a plate with some data collections, eg /containers/cid/340603
  • Select the Data Status radio button, and tick the Rank By box, choosing AP Resolution
  • Check there is another dropdown with default value All Pipelines, and other pipelines eg Fast DP, xia2/DIALS, autoPROC as the other options
  • Check changing the pipeline changes the colours on the wells. As an example, location 150 (G3 dot 2) has
    • poor resolution but good completeness for Fast DP
    • good resolution but poor completeness for xia2/DIALS
  • Check reverting to All Pipelines puts the colours back as they started

@ndg63276 ndg63276 marked this pull request as ready for review June 27, 2025 08:22
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.2 September 16, 2025 09:57
@ndg63276 ndg63276 merged commit 9309fc5 into pre-release/2025-R4.2 Sep 16, 2025
3 of 4 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1426/set-pipeline-when-ranking-samples branch September 16, 2025 10:00
ndg63276 added a commit that referenced this pull request Sep 30, 2025
@ndg63276
Merge pre-release/2025-R4.2 into master (#986)
2008454 
* LIMS-1844: Update archiving messages for 'il' proposals (#977)

* LIMS-1807: Leave 'Mark Dispensing' button active until cancelled (#967)

* LIMS-1799: Checks for safety level should be case insensitive (#955)

* LIMS-1786: Add Dewars column to Shipments page (#958)

* LIMS-1426: Allow setting of pipeline when ranking samples (#950)

* LIMS-1783: Add parent container dropdown for gridboxes (#965)

* LIMS-1903: Fix display of shipping labels (#984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gfrn gfrn gfrn approved these changes

Assignees

No one assigned

Labels

Ready to Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndg63276 @gfrn