Skip to content

LIMS-1798: Only show the latest dispensing position#952

Merged
ndg63276 merged 7 commits intopre-release/2025-R3.5from
fix/LIMS-1798/only-show-latest-dispensing-position
Jul 22, 2025
Merged

LIMS-1798: Only show the latest dispensing position#952
ndg63276 merged 7 commits intopre-release/2025-R3.5from
fix/LIMS-1798/only-show-latest-dispensing-position

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1798

Summary:

#869 introduced display/editing of the dispensing position, but I hadn't anticipated that each sample would have a new dispensing position for each imaging. This PR is to only show and edit the most recent dispensing position.

Changes:

  • Use a subquery to only get the most recent blsampleposition entry

To test:

  • Go to a container with multiple dispensing positions, eg /containers/cid/338794 well 2
  • Check only one dispensing position is displayed in Synchweb (white circle with D inside)
  • Use the Mark Dispensing button to edit the position, check the most recent value in the database has been updated, eg
SELECT location, name, blsamplepositionid, posX, posY FROM BLSample LEFT OUTER JOIN BLSamplePosition using (blSampleId) WHERE containerId=338794 and location=2;
  • Click Mark Dispensing again, and then click Delete. Check the most recent values are now NULL.

ndg63276 and others added 6 commits June 24, 2025 15:20
* LIMS-1550: Add 'Mark Dispensing' button to plate well view

* LIMS-1550: Dont throw an error if no subsamples exist

* LIMS-1550: Use new BLSamplePosition table

* LIMS-1550: Label positions as 'dispensing'

* LIMS-1550: Change plus signs to crosses when the button text changes

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Base automatically changed from pre-release/2025-R3.3 to master July 8, 2025 10:25
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.5 July 22, 2025 09:41
@ndg63276 ndg63276 merged commit f12d356 into pre-release/2025-R3.5 Jul 22, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1798/only-show-latest-dispensing-position branch July 22, 2025 09:44
ndg63276 added a commit that referenced this pull request Aug 26, 2025
* LIMS-742: Remove redundant 'pid' check (#961)

* LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans (#956)

* LIMS-1792: Allow container types from multiple villages (#960)

* LIMS-1796: Display filepath for attachments (#959)

* LIMS-1798: Only show the latest dispensing position (#952)

* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869)

* LIMS-167: Dont default to mx type for calendar/logistics views (#942)

* LIMS-1716: Multicrystal processing only shows one DC per group (#938)

* LIMS-1718: Display cluster info on multiplex jobs (#937)

* LIMS-1752: Create view for Ligand Fit pipeline (#943)

* LIMS-1833: Fix XPDF DC view (#963)

* LIMS-1845: Fix broken VMXi attachment names (#968)

* LIMS-1848: Fix bug where no container types are available (#971)

* Check type before assigning to proposal object (#975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants