Skip to content

LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans#956

Merged
ndg63276 merged 5 commits intopre-release/2025-R3.5from
improvement/LIMS-1780/show-dials.align_crystal-results-on-characterizations
Jul 22, 2025
Merged

LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans#956
ndg63276 merged 5 commits intopre-release/2025-R3.5from
improvement/LIMS-1780/show-dials.align_crystal-results-on-characterizations

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jul 9, 2025

JIRA ticket: LIMS-1780
JIRA ticket: LIMS-1787

Summary:

The dials.align_crystal strategy pipeline is run on data collections of type 'characterization', we should display the results.
Some grid scans also have xia2.ssx run on them, we should display the results.

Changes:

  • Move the logic of which result bars to display out of the HTML template and into the JS
  • Show both strategies and processing if data collection type is 'characterization', otherwise unchanged
  • Give strategy results a h2 header as h1 seems to be ignored (downstream results use h2 also)
  • Show auto processing bar on grid scans if results are available

To test:

  • Go to a characterization data collection (eg /dc/visit/mx37593-47/id/18698689), check bars are shown for Strategies, Auto Processing and Downstream Processing
  • Go to a data collection with non-zero overlap (eg /dc/visit/mx39189-13/id/18634663), check only the Strategies bar is shown
  • Go to a data collection with zero overlap that is not Characterization (eg /dc/visit/mx23694-138/id/18609703), check only Auto Processing and Downstream Processing bars are shown
  • Go to a data collection that is part of a 3d grid scan (eg /dc/visit/mx23694-138/id/18609694), check only an Xray Centring bar is shown
  • Go back to /dc/visit/mx37593-47/id/18698689, check the Strategies bar opens, a result is shown, and the program name is underlined. Repeat with /dc/visit/mx39189-13/id/18634663.
  • Go to a grid scan with xia2.ssx results (eg /dc/visit/nt37104-159/id/18277888), check the Auto Processing bar is shown
  • Go to a grid scan that has no auto processing results and is not part of a 3d grid scan (eg /dc/visit/cm40608-3/id/18713461), check neither bar is shown.

@ndg63276 ndg63276 changed the title LIMS-1780: Show dials.align_crystal results on characterizations LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans Jul 9, 2025
Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk>
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.5 July 22, 2025 09:41
@ndg63276 ndg63276 merged commit bc23d84 into pre-release/2025-R3.5 Jul 22, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1780/show-dials.align_crystal-results-on-characterizations branch July 22, 2025 09:43
ndg63276 added a commit that referenced this pull request Aug 26, 2025
* LIMS-742: Remove redundant 'pid' check (#961)

* LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans (#956)

* LIMS-1792: Allow container types from multiple villages (#960)

* LIMS-1796: Display filepath for attachments (#959)

* LIMS-1798: Only show the latest dispensing position (#952)

* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869)

* LIMS-167: Dont default to mx type for calendar/logistics views (#942)

* LIMS-1716: Multicrystal processing only shows one DC per group (#938)

* LIMS-1718: Display cluster info on multiplex jobs (#937)

* LIMS-1752: Create view for Ligand Fit pipeline (#943)

* LIMS-1833: Fix XPDF DC view (#963)

* LIMS-1845: Fix broken VMXi attachment names (#968)

* LIMS-1848: Fix bug where no container types are available (#971)

* Check type before assigning to proposal object (#975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants