Skip to content

LIMS-1792: Allow container types from multiple villages#960

Merged
ndg63276 merged 1 commit intopre-release/2025-R3.5from
improvement/LIMS-1792/allow-container-types-from-multiple-villages
Jul 22, 2025
Merged

LIMS-1792: Allow container types from multiple villages#960
ndg63276 merged 1 commit intopre-release/2025-R3.5from
improvement/LIMS-1792/allow-container-types-from-multiple-villages

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1792

Summary:

Some proposals have visits on multiple villages, eg sm, mx. They should be able to create containers in types that belong to each village.

Changes:

  • Return an additional field 'TYPES' for each proposal, as an array of all villages associated with the proposal
  • Store this in the proposal store
  • Use it to display more container types if needed

To test:

  • Go to a proposal with multiple villages, eg nt40910. Make a new container, check the container type dropdown gives grouped options for sm Puck-16's, as well as mx pucks and plates.
  • Go to an mx-only propsosal eg mx23694. Make a new container, check the container type dropdown only shows mx container types.
  • Go to an sm-only propsosal eg cm40638. Make a new container, check the container type dropdown only shows sm container types.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.5 July 22, 2025 09:41
@ndg63276 ndg63276 merged commit f9012ac into pre-release/2025-R3.5 Jul 22, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1792/allow-container-types-from-multiple-villages branch July 22, 2025 09:44
ndg63276 added a commit that referenced this pull request Aug 26, 2025
* LIMS-742: Remove redundant 'pid' check (#961)

* LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans (#956)

* LIMS-1792: Allow container types from multiple villages (#960)

* LIMS-1796: Display filepath for attachments (#959)

* LIMS-1798: Only show the latest dispensing position (#952)

* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869)

* LIMS-167: Dont default to mx type for calendar/logistics views (#942)

* LIMS-1716: Multicrystal processing only shows one DC per group (#938)

* LIMS-1718: Display cluster info on multiplex jobs (#937)

* LIMS-1752: Create view for Ligand Fit pipeline (#943)

* LIMS-1833: Fix XPDF DC view (#963)

* LIMS-1845: Fix broken VMXi attachment names (#968)

* LIMS-1848: Fix bug where no container types are available (#971)

* Check type before assigning to proposal object (#975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants