Skip to content

LIMS-742: Remove redundant 'pid' check#961

Merged
ndg63276 merged 5 commits intopre-release/2025-R3.5from
improvement/LIMS-742/remove-redundant-pid-check
Jul 22, 2025
Merged

LIMS-742: Remove redundant 'pid' check#961
ndg63276 merged 5 commits intopre-release/2025-R3.5from
improvement/LIMS-742/remove-redundant-pid-check

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-742

Summary:

Since #566, there has been code left in to check if $pid was being sent to the api/users/ endpoint. As it doesn't seem to be, we can remove that logging, and also remove the $pid variable.

Changes:

  • Remove $pid and logging of $pid

To test:

  • Go to the home page, hover over the users icon for a visit, check a list of users appears
  • Go to a visit, hover over the Users icon at the top, check a list of users appears
  • Go to /projects, and create a new project. Add a user to the project by searching, and check they remain after refreshing the page
  • Go to /contacts and click Add Home Lab Contact. Check your name appears in the dropdown labelled Login.
  • Go to a shipment and click to add a container. Check a list of people appears in the dropdown labelled Owner.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.5 July 22, 2025 09:40
@ndg63276 ndg63276 merged commit 87c8e24 into pre-release/2025-R3.5 Jul 22, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-742/remove-redundant-pid-check branch July 22, 2025 09:43
ndg63276 added a commit that referenced this pull request Aug 26, 2025
* LIMS-742: Remove redundant 'pid' check (#961)

* LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans (#956)

* LIMS-1792: Allow container types from multiple villages (#960)

* LIMS-1796: Display filepath for attachments (#959)

* LIMS-1798: Only show the latest dispensing position (#952)

* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869)

* LIMS-167: Dont default to mx type for calendar/logistics views (#942)

* LIMS-1716: Multicrystal processing only shows one DC per group (#938)

* LIMS-1718: Display cluster info on multiplex jobs (#937)

* LIMS-1752: Create view for Ligand Fit pipeline (#943)

* LIMS-1833: Fix XPDF DC view (#963)

* LIMS-1845: Fix broken VMXi attachment names (#968)

* LIMS-1848: Fix bug where no container types are available (#971)

* Check type before assigning to proposal object (#975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants