Skip to content

LIMS-1856: Fix offset for plates#973

Merged
ndg63276 merged 1 commit intopre-release/2025-R4.1from
fix/LIMS-1856/incorrect-reservoir-location
Sep 2, 2025
Merged

LIMS-1856: Fix offset for plates#973
ndg63276 merged 1 commit intopre-release/2025-R4.1from
fix/LIMS-1856/incorrect-reservoir-location

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Aug 6, 2025

JIRA ticket: LIMS-1856

Summary:

The reservoir for a MRC 2 Drop plate is on the left side, but Synchweb shows it on the right. The database has dropOffsetX=0.5, but this is not used anywhere.

Changes:

  • Pull the drop offset values from the database and pass them to the client
  • Use the offsets to move the drops around in the well. Drop offset values should be between 0 and 1.

To test:

  • Go to any proposal, then add a container to a shipment
  • Choose container type MRC 2 Drop, check the drops are on the right and the reservoir on the left
  • Create the container, check there are no errors.
  • View the created container, check the layout is still the same (this is rendered in a different way and is unchanged)

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.1 September 2, 2025 10:07
@ndg63276 ndg63276 merged commit df1414c into pre-release/2025-R4.1 Sep 2, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1856/incorrect-reservoir-location branch September 2, 2025 10:07
ndg63276 added a commit that referenced this pull request Sep 16, 2025
* LIMS-1856: Fix offset for plates (#973)

* LIMS-1839: Fix fast_dp radiation damage plots (#964)

* LIMS-1814: Add min images filter to summary page (#966)

* LIMS-1804: Make barcode be required for new plates (#969)

* LIMS-1802: Improvements to Add Shipment page (#972)

* LIMS-1784: Add drawing for Cryo EM Puck (#970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants