Fix proposal type assignment#975
Merged
gfrn merged 1 commit intopre-release/2025-R3.5.2from Aug 12, 2025
Merged
Conversation
MattPrit
approved these changes
Aug 12, 2025
gfrn
changed the base branch from
pre-release/2025-R3.5.1
to
pre-release/2025-R3.5.2
ndg63276
added a commit
that referenced
this pull request
Aug 26, 2025
* LIMS-742: Remove redundant 'pid' check (#961) * LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans (#956) * LIMS-1792: Allow container types from multiple villages (#960) * LIMS-1796: Display filepath for attachments (#959) * LIMS-1798: Only show the latest dispensing position (#952) * LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869) * LIMS-167: Dont default to mx type for calendar/logistics views (#942) * LIMS-1716: Multicrystal processing only shows one DC per group (#938) * LIMS-1718: Display cluster info on multiplex jobs (#937) * LIMS-1752: Create view for Ligand Fit pipeline (#943) * LIMS-1833: Fix XPDF DC view (#963) * LIMS-1845: Fix broken VMXi attachment names (#968) * LIMS-1848: Fix bug where no container types are available (#971) * Check type before assigning to proposal object (#975)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Sometimes, the proposal type is set to "null" during the process in which we determine the proposal type, and therefore, defaults to "gen". This checks that the determined proposal type is not null before assigning it to the final proposal object.
Changes:
To test:
nullproposal type from_get_type_from_beamline(such as sw30864)