Skip to content

LIMS-124: Display Anode results#981

Merged
ndg63276 merged 2 commits intopre-release/2025-R4.3from
improvement/LIMS-124/display-anode-results
Sep 30, 2025
Merged

LIMS-124: Display Anode results#981
ndg63276 merged 2 commits intopre-release/2025-R4.3from
improvement/LIMS-124/display-anode-results

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Sep 16, 2025

JIRA ticket: LIMS-124

Summary:

Anode has been running at the end of Dimple for a few years, we should display the results in Synchweb, not just in obscure log files.

NB This PR does not include a map viewer for Anode results, but that is intended to follow at some point, ticket LIMS-598.

Screenshot:

image

Changes:

  • Add method to the backend to return Anode results with the Dimple results
  • Add a table of Anode results to the Dimple view, under the table of Dimple results
  • Add a plot of peak height vs site number, under the Dimple plot
  • Fix a bug in xhrimage if onerror is not defined

To test:

  • Go to a data collection with a Dimple success eg /dc/visit/cm40607-3/id/19541770
  • Expand the Downstream Processing bar, and click the Dimple tag
  • Check there is a table of 10 Anode peaks, and a plot of their heights
  • Go to a data collection with Dimple but no Anode results, eg /dc/visit/cm28170-5/id/7330809, check there is a message saying 'No Anode peaks found'

@ndg63276 ndg63276 marked this pull request as ready for review September 16, 2025 09:23
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.3 September 30, 2025 11:23
@ndg63276 ndg63276 merged commit ed21891 into pre-release/2025-R4.3 Sep 30, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-124/display-anode-results branch September 30, 2025 11:26
ndg63276 added a commit that referenced this pull request Oct 14, 2025
* LIMS-1902: Fix plate inspection view for MRC 2 Drop plates (#983)

* LIMS-1902: Fix plate inspection view for MRC 2 Drop plates

* LIMS-1902: Remove whitespace change

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-124: Display Anode results (#981)

* LIMS-124: Display Anode results

* LIMS-124: Round numbers

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1785: Create 'Assign Sample' page for VMXm (#974)

* LIMS-1785: Create 'Assign Sample' page for VMXm

* LIMS-1785: Label link to Assign page correctly

* LIMS-1785: Use consts rather than vars

* LIMS-1785: Fix unassign dialog

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1785: Make sample assign page look for containers on the beamline, not dewars

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant